From d5f8289bcd1ec0d08bc36501e2c1b1dbdf557d1b Mon Sep 17 00:00:00 2001 From: Jeroen Ketema Date: Tue, 12 Aug 2025 13:01:31 +0200 Subject: [PATCH 1/5] Go: Update Go version in tests to 1.25.0 --- go/actions/test/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go/actions/test/action.yml b/go/actions/test/action.yml index f777535fec17..d64142115f01 100644 --- a/go/actions/test/action.yml +++ b/go/actions/test/action.yml @@ -4,7 +4,7 @@ inputs: go-test-version: description: Which Go version to use for running the tests required: false - default: "~1.24.0" + default: "~1.25.0" run-code-checks: description: Whether to run formatting, code and qhelp generation checks required: false From 4baf115c3aae5df254ec7a424c13f36617c25d19 Mon Sep 17 00:00:00 2001 From: Jeroen Ketema Date: Tue, 12 Aug 2025 13:13:41 +0200 Subject: [PATCH 2/5] Go: Use Go 1.25.0 to build the Go extractor --- MODULE.bazel | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MODULE.bazel b/MODULE.bazel index 8bf127ba00ff..f90a28271faa 100644 --- a/MODULE.bazel +++ b/MODULE.bazel @@ -263,7 +263,7 @@ use_repo( ) go_sdk = use_extension("@rules_go//go:extensions.bzl", "go_sdk") -go_sdk.download(version = "1.24.0") +go_sdk.download(version = "1.25.0") go_deps = use_extension("@gazelle//:extensions.bzl", "go_deps") go_deps.from_file(go_mod = "//go/extractor:go.mod") From 976ef99d60e9cc2828b83ab1cd90efa652712b3c Mon Sep 17 00:00:00 2001 From: Jeroen Ketema Date: Tue, 12 Aug 2025 14:25:19 +0200 Subject: [PATCH 3/5] Go: Request go1.25.0 toolchain --- go/extractor/go.mod | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/go/extractor/go.mod b/go/extractor/go.mod index 927cf8e05123..8ec7ec72fc27 100644 --- a/go/extractor/go.mod +++ b/go/extractor/go.mod @@ -1,8 +1,8 @@ module github.com/github/codeql-go/extractor -go 1.24 +go 1.25 -toolchain go1.24.0 +toolchain go1.25.0 // when updating this, run // bazel run @rules_go//go -- mod tidy From 5e2a5600a78c537dc4f6af97bfa6a59c768624f1 Mon Sep 17 00:00:00 2001 From: Jeroen Ketema Date: Wed, 13 Aug 2025 13:40:14 +0200 Subject: [PATCH 4/5] Update `go_rules` to the latest version This version includes https://github.com/bazel-contrib/rules_go/pull/4397 which addresses the build fialure we were seeing. --- MODULE.bazel | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MODULE.bazel b/MODULE.bazel index f90a28271faa..52c07a395b5e 100644 --- a/MODULE.bazel +++ b/MODULE.bazel @@ -15,7 +15,7 @@ local_path_override( # see https://registry.bazel.build/ for a list of available packages bazel_dep(name = "platforms", version = "0.0.11") -bazel_dep(name = "rules_go", version = "0.50.1") +bazel_dep(name = "rules_go", version = "0.56.1") bazel_dep(name = "rules_pkg", version = "1.0.1") bazel_dep(name = "rules_nodejs", version = "6.2.0-codeql.1") bazel_dep(name = "rules_python", version = "0.40.0") From 4b215d50e27268dc050c4895b75c67ef22afdb7c Mon Sep 17 00:00:00 2001 From: Jeroen Ketema Date: Wed, 13 Aug 2025 14:09:53 +0200 Subject: [PATCH 5/5] Go: Update `maxGoVersion` in the autobuilder --- go/extractor/autobuilder/build-environment.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go/extractor/autobuilder/build-environment.go b/go/extractor/autobuilder/build-environment.go index e207e5ad0267..0a4c7e2983b4 100644 --- a/go/extractor/autobuilder/build-environment.go +++ b/go/extractor/autobuilder/build-environment.go @@ -12,7 +12,7 @@ import ( ) var minGoVersion = util.NewSemVer("1.11") -var maxGoVersion = util.NewSemVer("1.24") +var maxGoVersion = util.NewSemVer("1.25") type versionInfo struct { goModVersion util.SemVer // The version of Go found in the go directive in the `go.mod` file.