simplify get/set VerticallScroll::visual_height

Author: xlai89

src/components/commit_details/details.rs

@@ -285,7 +285,6 @@ impl DrawableComponent for DetailsComponent {
 		let height = chunks[1].height.saturating_sub(border_width);
 
 		self.current_size.set((width, height));
-		self.scroll.set_visual_height(usize::from(height));
 
 		let number_of_lines = Self::get_number_of_lines(
 			self.data.as_ref(),

src/components/utils/scroll_vertical.rs

@@ -20,14 +20,6 @@ impl VerticalScroll {
 		}
 	}
 
-	pub fn set_visual_height(&self, height: usize) {
-		self.visual_height.set(height);
-	}
-
-	pub fn get_visual_height(&self) -> usize {
-		self.visual_height.get()
-	}
-
 	pub fn get_top(&self) -> usize {
 		self.top.get()
 	}
@@ -44,10 +36,10 @@ impl VerticalScroll {
 			ScrollType::Down => old.saturating_add(1),
 			ScrollType::Up => old.saturating_sub(1),
 			ScrollType::PageDown => old
-				.saturating_add(self.get_visual_height())
+				.saturating_add(self.visual_height.get())
 				.saturating_sub(1),
 			ScrollType::PageUp => old
-				.saturating_sub(self.get_visual_height())
+				.saturating_sub(self.visual_height.get())
 				.saturating_add(1),
 			ScrollType::Home => 0,
 			ScrollType::End => max,
@@ -96,6 +88,8 @@ impl VerticalScroll {
 		selection_max: usize,
 		visual_height: usize,
 	) -> usize {
+		self.visual_height.set(visual_height);
+
 		let new_top = calc_scroll_top(
 			self.get_top(),
 			visual_height,