Prevent exceptions being masked by undefined method errors in ruby 2.4 #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can confirm. This makes it usable in my project. Please merge it! |
|
This came up for me today too. It exposed an actual error from graphviz (not a helpful error, but at least an error). Please merge this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@glejeune - This may be a ruby 2.4 idiosynracy, I didn't take the time to diagnose it further.
Essentially, sometimes the status returned from output_and_errors_from_command is nil, which does not respond to
zero?; causing the actual commands errors to be masked.This patches that so the underlying graphviz usage errors can bubble up.
I believe this resolves both #133 and #125