## 1.9.1 - July 2022

* Fixes duplicate entries bug that happens when adding custom regex rule with same name.
  * Message changed from `Error: "SomeRuleName" can not be used as eslint-plugin-regex rule name` to `Error: "SomeRuleName" already defined as eslint-plugin-regex rule name`.
* Updates documentation.
  * Changes background color to white for images.

Author: gmullerb

CHANGELOG.md

@@ -1,5 +1,12 @@
 # ESLint Plugin Regex Change Log
 
+## 1.9.1 - July 2022
+
+* Fixes duplicate entries bug that happens when adding custom regex rule with same name.
+  * Message changed from `Error: "SomeRuleName" can not be used as eslint-plugin-regex rule name` to `Error: "SomeRuleName" already defined as eslint-plugin-regex rule name`.
+* Updates documentation.
+  * Changes background color to white for images.
+
 ## 1.9.0 - April 2022
 
 * Closes #15, Allowing mixing different error level.

README.md

@@ -28,7 +28,7 @@ __________________
   },
   "devDependencies": {
     "eslint": ">=4.0.0",
-    "eslint-plugin-regex": "1.9.0",
+    "eslint-plugin-regex": "1.9.1",
 ```
 
 2 . Configure eslint:
@@ -795,7 +795,7 @@ Creating and Using a Custom Set of regex rules **requires using `js` files**.
 
 ###### Named Regex Rules approach
 
-Rule name can be anything that includes `invalid`, `disuse`, `avoid`, `required` or `use`, ignoring letter case, and with the restrictions of predefined names (`invalid`, `disuse`, `avoid`, `invalid-warn`, `invalid-error`, `another-invalid`, `other-invalid`, `required`, `use`, `required-warn`, `required-error`, `another-required` and `other-required`), this will allow to mix different error levels or create custom regex rules package.
+A regex rule can be named with a custom name. The Rule name can be anything that **includes `invalid`, `disuse`, `avoid`, `required` or `use`**, ignoring letter case, and with the restrictions of predefined names (`invalid`, `disuse`, `avoid`, `invalid-warn`, `invalid-error`, `another-invalid`, `other-invalid`, `required`, `use`, `required-warn`, `required-error`, `another-required` and `other-required`).
 
 * `regex/*invalid*`, `regex/*disuse*`  or `regex/*avoid*` for invalid patterns.
 * `regex/*required*` or `regex/*use*` for required patterns.
@@ -813,26 +813,11 @@ addRegexRuleName('*invalid*')
 addRegexRuleName('*required*')
 ```
 
-An advantage of using Named Regex Rules is that shown error will be even more specific, e.g.:
-
-```javascript
-const { addRegexRuleName } = require('eslint-plugin-regex')
-
-addRegexRuleName('required-custom-896')
-```
-
-then, if an error happens, the output will be something similar to:
-
-```sh
-/path/to/some.js
-  1:1  error  Required regular expression /requiredRegex/gm not found in file  regex/required-custom-896
-```
-
-instead of
+* If the custom regex rule name is already defined, then an error will be shown:
 
 ```sh
-/path/to/some.js
-  1:1  error  Required regular expression /requiredRegex/gm not found in file  regex/required
+Error: Cannot read config file: /path/to/.eslintrc.js
+Error: "SomeRuleName" already defined as eslint-plugin-regex rule name
 ```
 
 ***Local Custom Regex rules***
@@ -955,6 +940,36 @@ mixing with other regex rules:
     ],
 ```
 
+***Advantages***
+
+* Using Named Regex rule name will allow to have a **set of different regex rule**:
+  * Each rule with totally different settings.
+    * Allow to mix different regular expressions.
+    * Allow to mix different error levels.
+    * etc.
+  * Easily create custom regex rules package.
+* When using Named Regex Rules, shown **errors will be even more specific**, e.g.:
+
+```javascript
+const { addRegexRuleName } = require('eslint-plugin-regex')
+
+addRegexRuleName('required-custom-896')
+```
+
+then, if an error happens, the output will be something similar to:
+
+```sh
+/path/to/some.js
+  1:1  error  Required regular expression /requiredRegex/gm not found in file  regex/required-custom-896
+```
+
+instead of
+
+```sh
+/path/to/some.js
+  1:1  error  Required regular expression /requiredRegex/gm not found in file  regex/required
+```
+
 ###### Import/Export approach
 
 Create a custom npm package using either with `json` or `js` files and add the custom regex rules.

lib/index.js

@@ -7,9 +7,9 @@ const rulesNames = ['required', 'use', 'required-warn', 'required-error', 'anoth
 module.exports = {
   addRegexRuleName: (ruleName) => {
     if (/use|avoid|disuse|invalid|required/i.test(ruleName)) {
-      if (/^(?:required|use|required-warn|required-error|another-required|other-required|invalid|disuse|avoid|invalid-warn|invalid-error|another-invalid|other-invalid)$/i // eslint-disable-line max-len
-        .test(ruleName)) {
-        throw new Error(`"${ruleName}" can not be used as eslint-plugin-regex rule name`)
+      const candidate = ruleName.toUpperCase()
+      if (rulesNames.findIndex(ruleName => ruleName.toUpperCase() === candidate) !== -1) {
+        throw new Error(`"${ruleName}" already defined as eslint-plugin-regex rule name`)
       }
       rulesNames.push(ruleName)
     }

package-lock.json

@@ -1,7 +1,7 @@
 {
   "name": "eslint-plugin-regex",
   "description": "ESLint rules using Regular Expression",
-  "version": "1.9.0",
+  "version": "1.9.1",
   "license": "MIT",
   "author": "Gonzalo Müller Bravo",
   "main": "lib/index.js",

package.json

@@ -51,15 +51,26 @@ describe('index tests', () => {
 
     for(const ruleName of rulesNames) {
       const testRuleName = ruleName.toUpperCase()
-      it(`should not regex rule name when equal to ${ruleName}`, () => {
+      it(`should not add regex rule name when equal to ${ruleName}`, () => {
         try {
           addRegexRuleName(testRuleName)
           fail(`Should not add "${ruleName}" name`)
         }
         catch(error) {
-          expect(error.toString()).toBe(`Error: "${testRuleName}" can not be used as eslint-plugin-regex rule name`)
+          expect(error.toString()).toBe(`Error: "${testRuleName}" already defined as eslint-plugin-regex rule name`)
         }
       })
     }
+
+    it('should fail adding same rule name more than once', () => {
+      addRegexRuleName('Same Required Rule Name')
+      try {
+        addRegexRuleName('Same Required Rule Name')
+        fail('Should not add "Same Required Rule Name" name')
+      }
+      catch(error) {
+        expect(error.toString()).toBe('Error: "Same Required Rule Name" already defined as eslint-plugin-regex rule name')
+      }
+    })
   })
 })