EditorBuilder registers deprecated PhpSearchStrategy

[davidgorges]

The triggered \E_USER_DEPRECATED errors cause phpunit to fail.

If anyone else runs into that:
\PHPUnit_Framework_Error_Deprecated::$enabled = FALSE;
disables the test fails.

[gnugat]

Hi @davidgorges thanks for your report. I'll remove PhpSearchStrategy from EditorBuilder to avoid this notice.

[wouterj]

@gnugat it can't be removed, as it's there for BC reasons. I think there are 2 options:

1. Instead of adding it as first search strategy, add it as last, so with normal usage, the notice won't be triggered (initializing the class doesn't trigger the deprecation notice)
2. Remove the trigger from PhpSearchStrategy#supports(). Again, this would avoid getting the error, unless someone uses the PhpSearchStrategy explicitely. In that case, it should get this notice.

[gnugat]

@wouterj good point, I'll try your first advice, if it doesn't do the trick I'll check the second :)

[gnugat]

@davidgorges could you provide us with a small piece of code to reproduce the issue? I'd like to add a test for it.

[wouterj]

@gnugat I think this will do (didn't test it though):

$editor = EditorFactory::createEditor();
$editor->findBelow('something');

[gnugat]

That's weird, example is full of tests that use EditorFactory::createEditor() + $editor#jumpBelow() and we never had a failure caused by PHP notice...

[wouterj]

@gnugat try with a line number search pattern. As that's the only strategy registered after the PHP search strategy (I forget about the priorty argument my previous comments). https://github.com/gnugat/redaktilo/blob/master/src/Gnugat/Redaktilo/Service/EditorBuilder.php#L86-L89

With all other patterns, there is a matching strategy stopping the iteration.

[gnugat]

@wouterj good point! LineNumberSearchStrategy is also deprecated, so I've added a test checking the notice (should be about LineNumberSearchStrategy and not PhpSearchStrategy).