Improve inspection for non-local type definitions (fixes #2269)

Author: dlsniper

src/com/goide/inspections/GoMethodOnNonLocalTypeInspection.java

@@ -39,7 +39,7 @@ public void visitMethodDeclaration(@NotNull final GoMethodDeclaration method) {
         if (methodType == null ||
             methodType.getTypeReferenceExpression() == null) return;
 
-        methodType = GoPsiImplUtil.findBaseTypeFromRef(methodType.getTypeReferenceExpression());
+        methodType = GoPsiImplUtil.findTypeFromTypeRef(methodType.getTypeReferenceExpression());
         if (methodType == null) return;
 
         String typeImportPath = ((GoFile)methodType.getContainingFile()).getImportPath();

src/com/goide/psi/impl/GoPsiImplUtil.java

@@ -486,7 +486,7 @@ public static GoType typeOrParameterType(@NotNull final GoTypeOwner resolve, @Nu
   }
 
   @Nullable
-  private static GoType findTypeFromTypeRef(@Nullable GoTypeReferenceExpression expression) {
+  public static GoType findTypeFromTypeRef(@Nullable GoTypeReferenceExpression expression) {
     PsiReference reference = expression != null ? expression.getReference() : null;
     PsiElement resolve = reference != null ? reference.resolve() : null;
     if (resolve instanceof GoTypeSpec) return ((GoTypeSpec)resolve).getSpecType();

testData/highlighting/methodOnNonLocalType.go

@@ -1,6 +1,11 @@
 package demo2031
 
-import . "fmt"
+import (
+	. "fmt"
+	"time"
+)
+
+type Duration time.Duration
 
 func (_ *string) <error descr="Method defined on non-local type">Demo</error>() {
 
@@ -13,3 +18,8 @@ func (_ int) <error descr="Method defined on non-local type">Demo</error>() {
 func (_ ScanState) <error descr="Method defined on non-local type">Demo</error>() {
 
 }
+
+func (_ *Duration) UnmarshalText(data []byte) (err error) {
+	_ = data
+	return nil
+}