runtime: include stderr when objdump fails

prattmic · gopherbot · commit 9693b94be057 · 2025-09-19T12:34:15.000-07:00
If objdump panics, we want the panic included in the test log. Change-Id: I6a6a636c13c5ba08acaa1c6c8714541a8e91542b Reviewed-on: https://go-review.googlesource.com/c/go/+/704338 Reviewed-by: Florian Lehner <lehner.florian86@gmail.com> Auto-Submit: Michael Pratt <mpratt@google.com> Reviewed-by: Michael Knyszek <mknyszek@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
diff --git a/src/runtime/unsafepoint_test.go b/src/runtime/unsafepoint_test.go
@@ -43,7 +43,7 @@ func TestUnsafePoint(t *testing.T) {
 	cmd := exec.Command(testenv.GoToolPath(t), "tool", "objdump", "-s", "setGlobalPointer", os.Args[0])
 	out, err := cmd.CombinedOutput()
 	if err != nil {
-		t.Fatalf("can't objdump %v", err)
+		t.Fatalf("can't objdump %v:\n%s", err, out)
 	}
 	lines := strings.Split(string(out), "\n")[1:]
 

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ func TestUnsafePoint(t *testing.T) {`
`43`	`43`	`cmd := exec.Command(testenv.GoToolPath(t), "tool", "objdump", "-s", "setGlobalPointer", os.Args[0])`
`44`	`44`	`out, err := cmd.CombinedOutput()`
`45`	`45`	`if err != nil {`
`46`		`- t.Fatalf("can't objdump %v", err)`
	`46`	`+ t.Fatalf("can't objdump %v:\n%s", err, out)`
`47`	`47`	`}`
`48`	`48`	`lines := strings.Split(string(out), "\n")[1:]`
`49`	`49`