Skip to content

fix(lit): correct HTML attribute binding and state reflection in MultipleChoice [Issue #574] #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shantoislamdev wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(lit): correct HTML attribute binding and state reflection in MultipleChoice [Issue #574] #575

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfda784
fix(lit): correct html attribute binding and state reflection in Mult…
shantoislamdev Jan 29, 2026
a756049
Merge branch 'main' into fix/lit-multiple-choice-binding
shantoislamdev Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion renderers/lit/src/0.8/ui/multiple-choice.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,15 @@ export class MultipleChoice extends Root {
}

render() {
const selectedValue = Array.isArray(this.selections)
? this.selections[0] || ""
: extractStringValue(
this.selections,
this.component,
this.processor,
this.surfaceId
) || "";

return html`<section class=${classMap(
this.theme.components.MultipleChoice.container
)}>
Expand All @@ -114,6 +123,7 @@ export class MultipleChoice extends Root {
name="data"
id="data"
class=${classMap(this.theme.components.MultipleChoice.element)}
.value=${selectedValue}
style=${
this.theme.additionalStyles?.MultipleChoice
? styleMap(this.theme.additionalStyles?.MultipleChoice)
Expand All @@ -134,7 +144,7 @@ export class MultipleChoice extends Root {
this.processor,
this.surfaceId
);
return html`<option ${option.value}>${label}</option>`;
return html`<option value=${option.value}>${label}</option>`;
})}
</select>
</section>`;
Expand Down