Bazel/Blaze BUILD

[cpsauer]

Hey Googlers!

Any chance you'd be down to release the Blaze/Bazel (Blazel!) BUILD files for this code? Would be handy to those of use building with Bazel.

Two of the external dependencies have done so already (nanopb and PromisesObjC), and I'd asked GoogleUtilities if they'd do the same in google/GoogleUtilities#72

If useful, here's one I spun up for my own quick use.

# Created from https://github.com/google/GoogleDataTransport/blob/1a65c30db4fc841e06586441682c2dda036d9db3/GoogleDataTransport.podspec

objc_library(
    name = "GoogleDataTransport",
    hdrs = glob(["GoogleDataTransport/GDTCORLibrary/Public/GoogleDataTransport/*.h"]),
    visibility = ["//visibility:public"],

    srcs = glob(["GoogleDataTransport/GDTCORLibrary/**/*", "GoogleDataTransport/GDTCCTLibrary/**/*"]),
    deps = [
        "@GooglePromises//:FBLPromises",
        "@GoogleUtilities//:Environment",
        "@GoogleUtilities//:Logger",
        "@nanopb//:nanopb",
    ],
    sdk_frameworks = [
        "CoreTelephony",
        "SystemConfiguration",
    ],
    sdk_dylibs = ["libz"],
)

Thanks for your consideration!
Chris
(ex-Googler)

P.S. To load nanopb, you'll need a patch file to enable malloc. To save time, here's one that works for the latest commit (2210cd92a6237a9ff82b58cfbe0c58da25ce1e11) that supports the compiled protos you're embedding

--- pb.h
+++ pb.h
@@ -13,2 +13,2 @@
 /* Enable support for dynamically allocated fields */
-/* #define PB_ENABLE_MALLOC 1 */
+#define PB_ENABLE_MALLOC 1

--- BUILD
+++ BUILD
@@ -7,2 +7,3 @@
 cc_library(
   name = "nanopb",
+  include_prefix = "nanopb",

[paulb777]

Hey @cpsauer! Thanks for the request. Would you provide a bit more context about how it would be used? Both GoogleUtilities and GoogleDataTransport are primarily support libraries used with other SDKs like Firebase. What is your use case?

From a Firebase perspective (and the Firebase team owns these two libraries), we'd be hesitant to add a fifth distribution method that has limited demand. See firebase/firebase-ios-sdk#6115.

Despite that, we could consider community support from a PR with an implementation that includes docs and GitHub Action tests.

[cpsauer]

Hey, Paul! Thanks for your response. Really appreciate your taking time to reply, even on a weekend.

Thanks for asking. The upstream use case is allowing the Google libraries they support (examples among many, ARCore, Firebase, etc) to be easily used from Bazel. If it's not a ton of overhead, I thought it'd be cool if they'd help support and foster Google's build ecosystem, too!

I wrote in because I figured you guys probably have BUILD files for them internally right? If so, might make sense to release them if they're the original source of truth anyway. And if not, kinda a shame for people to keep writing their own individual BUILD files. So I figured I'd toss 'em up in case they'd save anyone else time. Y'all are super welcome to use them of course--maybe they'd be handy inside of Google, too? Plus, you know, I like to make some effort to help things I see or use. Googliness still abounds :)

(Makes me sad to see that firebase/firebase-ios-sdk#6115 got kinda toxic. That's no fun. If useful context, I think maybe part of the frustration there is that PodToBUILD is unusably broken and unresponsive (in my experience), yet Bazel recommended. That's probably why you're hearing hollering about it, unfortunately.)

-C

[wweevv-johndpope]

I think I got a fix for this using xcframework - check the link
firebase/firebase-ios-sdk#6115

N.B. - you'll need to adjust these to suit
"ios_device": "ios-arm64",
"ios_simulator": "ios-arm64_x86_64-simulator",

/third-party/Firebase/FirebaseAnalytics/BUILD

load("@build_bazel_rules_apple//apple:apple.bzl",
    "apple_static_framework_import", "apple_dynamic_xcframework_import"
)




objc_library(
    name = "FirebaseAnalytics",
    deps = ["FBLPromisesXCFramework","FirebaseAnalyticsXCFramework","FirebaseAnalyticsSwiftXCFramework",
    "FirebaseCoreXCFramework","FirebaseCoreDiagnosticsXCFramework", "FirebaseCoreInternalXCFramework",
    "FirebaseInstallationsXCFramework","GoogleAppMeasurementXCFramework","GoogleAppMeasurementIdentitySupportXCFramework",
    "GoogleUtilitiesXCFramework","GoogleDataTransportXCFramework","nanopbXCFramework"],
    enable_modules = True,
    module_name = "FirebaseAnalytics",
    visibility = ["//visibility:public"],
)

apple_dynamic_xcframework_import(
    name = "FBLPromisesXCFramework",
    library_identifiers = {
        "ios_device": "ios-arm64",
        "ios_simulator": "ios-arm64_x86_64-simulator",
    },
    xcframework_imports = glob(["FBLPromises.xcframework/**"] ),
)

apple_dynamic_xcframework_import(
    name = "FirebaseAnalyticsXCFramework",
    library_identifiers = {
        "ios_device": "ios-arm64_armv7",
        "ios_simulator": "ios-arm64_i386_x86_64-simulator",
    },
    xcframework_imports = glob(["FirebaseAnalytics.xcframework/**"] ),
)

apple_dynamic_xcframework_import(
    name = "FirebaseAnalyticsSwiftXCFramework",
    library_identifiers = {
        "ios_device": "ios-arm64",
        "ios_simulator": "ios-arm64_x86_64-simulator",
    },
    xcframework_imports = glob(["FirebaseAnalyticsSwift.xcframework/**"] ),
)

apple_dynamic_xcframework_import(
    name = "FirebaseCoreXCFramework",
    library_identifiers = {
        "ios_device": "ios-arm64",
        "ios_simulator": "ios-arm64_x86_64-simulator",
    },
    xcframework_imports = glob(["FirebaseCore.xcframework/**"] ),
)

apple_dynamic_xcframework_import(
    name = "FirebaseCoreDiagnosticsXCFramework",
    library_identifiers = {
        "ios_device": "ios-arm64",
        "ios_simulator": "ios-arm64_x86_64-simulator",
    },
    xcframework_imports = glob(["FirebaseCoreDiagnostics.xcframework/**"] ),
)

apple_dynamic_xcframework_import(
    name = "FirebaseCoreInternalXCFramework",
    library_identifiers = {
        "ios_device": "ios-arm64",
        "ios_simulator": "ios-arm64_x86_64-simulator",
    },
    xcframework_imports = glob(["FirebaseCoreInternal.xcframework/**"] ),
)


apple_dynamic_xcframework_import(
    name = "FirebaseInstallationsXCFramework",
    library_identifiers = {
        "ios_device": "ios-arm64",
        "ios_simulator": "ios-arm64_x86_64-simulator",
    },
    xcframework_imports = glob(["FirebaseInstallations.xcframework/**"] ),
)


apple_dynamic_xcframework_import(
    name = "GoogleAppMeasurementXCFramework",
    library_identifiers = {
        "ios_device": "ios-arm64_armv7",
        "ios_simulator": "ios-arm64_i386_x86_64-simulator",
    },
    xcframework_imports = glob(["GoogleAppMeasurement.xcframework/**"] ),
)

apple_dynamic_xcframework_import(
    name = "GoogleAppMeasurementIdentitySupportXCFramework",
    library_identifiers = {
        "ios_device": "ios-arm64_armv7",
        "ios_simulator": "ios-arm64_i386_x86_64-simulator",
    },
    xcframework_imports = glob(["GoogleAppMeasurementIdentitySupport.xcframework/**"] ),
)

apple_dynamic_xcframework_import(
    name = "GoogleDataTransportXCFramework",
    library_identifiers = {
        "ios_device": "ios-arm64",
        "ios_simulator": "ios-arm64_x86_64-simulator",
    },
    xcframework_imports = glob(["GoogleDataTransport.xcframework/**"] ),
)


apple_dynamic_xcframework_import(
    name = "GoogleUtilitiesXCFramework",
    library_identifiers = {
        "ios_device": "ios-arm64",
        "ios_simulator": "ios-arm64_x86_64-simulator",
    },
    xcframework_imports = glob(["GoogleUtilities.xcframework/**"] ),
)


apple_dynamic_xcframework_import(
    name = "nanopbXCFramework",
    library_identifiers = {
        "ios_device": "ios-arm64",
        "ios_simulator": "ios-arm64_x86_64-simulator",
    },
    xcframework_imports = glob(["nanopb.xcframework/**"] ),
)

UPDATE

this approach by @vikage successfully wires up firebase + GoogleDataTransport
(I had some success with xcframwork above - but it was crashing with httpbody error. )

https://thanhvu.dev/2022/04/16/migrating-ios-project-to-bazel-part-6-tich-hop-firebase-crashlytics/
(just translate to english)

demo app (make sure you're on firebase branch
need to drop in google plist into app/resources folder
https://github.com/vikage/DemoBazel/blob/firebase/Thirdparty/Firebase/BUILD

[ncooke3]

Hi @wweevv-johndpope, just closing the loop with regard to the HTTPBody crash you mentioned. If it was from the Promises framework, that was recently fixed in Promises 2.3.1. This fix is included starting in the Firebase 10.13.0 release.