From ca10c612fb14cdb0daae8d1b88f28ca53421b493 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Wed, 5 Mar 2025 16:38:45 -0500 Subject: [PATCH 1/2] [Infra] Update README.md code formatting docs --- README.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index daa9913..ea26c62 100644 --- a/README.md +++ b/README.md @@ -206,9 +206,7 @@ Alternatively disable signing in each target: ### Code Formatting -To ensure that the code is formatted consistently, run the script -[./scripts/check.sh](https://github.com/firebase/firebase-ios-sdk/blob/main/scripts/check.sh) -before creating a PR. +See [firebase-ios-sdk's code formatting docs][firebase-ios-sdk-formatting]. GitHub Actions will verify that any code changes are done in a style compliant way. Install `clang-format` and `mint`: @@ -234,3 +232,4 @@ The contents of this repository is licensed under the [gh-actions]: https://github.com/firebase/firebase-ios-sdk/actions [gh-datatransport-badge]: https://github.com/firebase/firebase-ios-sdk/workflows/datatransport/badge.svg +[firebase-ios-sdk-formatting]: https://github.com/firebase/firebase-ios-sdk?tab=readme-ov-file#code-formatting From abdf40ebb2aa3e78182acbe7e50aa70ca0a1caa5 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Wed, 5 Mar 2025 16:39:15 -0500 Subject: [PATCH 2/2] Update README.md --- README.md | 8 -------- 1 file changed, 8 deletions(-) diff --git a/README.md b/README.md index ea26c62..067dafa 100644 --- a/README.md +++ b/README.md @@ -208,14 +208,6 @@ Alternatively disable signing in each target: See [firebase-ios-sdk's code formatting docs][firebase-ios-sdk-formatting]. -GitHub Actions will verify that any code changes are done in a style compliant -way. Install `clang-format` and `mint`: - -```console -brew install clang-format@19 -brew install mint -``` - ### Running Unit Tests Select a scheme and press Command-u to build a component and run its unit tests.