Skip to content

Commit c5795a3

Browse files
Adam LangleyBoringssl LUCI CQ
Adam Langley
authored and
Boringssl LUCI CQ
committed
Note a couple of typoed struct names that we'll leave alone.
Change-Id: I4f0774c8c986eb7b2c464b6ecc72c8b6aa00b350 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/78870 Auto-Submit: Adam Langley <agl@google.com> Reviewed-by: David Benjamin <davidben@google.com> Commit-Queue: David Benjamin <davidben@google.com>
1 parent abd20d6 commit c5795a3

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

crypto/fipsmodule/digest/internal.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ extern "C" {
2222
#endif
2323

2424

25+
// env_md_st is typoed ("evp" -> "env"), but the typo comes from OpenSSL and
26+
// some consumers forward-declare these structures so we're leaving it alone.
2527
struct env_md_st {
2628
// type contains a NID identifing the digest function. (For example,
2729
// NID_md5.)
@@ -55,11 +57,11 @@ struct env_md_st {
5557
struct evp_md_pctx_ops {
5658
// free is called when an |EVP_MD_CTX| is being freed and the |pctx| also
5759
// needs to be freed.
58-
void (*free) (EVP_PKEY_CTX *pctx);
60+
void (*free)(EVP_PKEY_CTX *pctx);
5961

6062
// dup is called when an |EVP_MD_CTX| is copied and so the |pctx| also needs
6163
// to be copied.
62-
EVP_PKEY_CTX* (*dup) (EVP_PKEY_CTX *pctx);
64+
EVP_PKEY_CTX *(*dup)(EVP_PKEY_CTX *pctx);
6365
};
6466

6567

include/openssl/digest.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
#ifndef OPENSSL_HEADER_DIGEST_H
1616
#define OPENSSL_HEADER_DIGEST_H
1717

18-
#include <openssl/base.h> // IWYU pragma: export
18+
#include <openssl/base.h> // IWYU pragma: export
1919

2020
#if defined(__cplusplus)
2121
extern "C" {
@@ -285,6 +285,9 @@ OPENSSL_EXPORT int EVP_MD_nid(const EVP_MD *md);
285285

286286
struct evp_md_pctx_ops;
287287

288+
// env_md_ctx_st is typoed ("evp" -> "env"), but the typo comes from OpenSSL
289+
// and some consumers forward-declare these structures so we're leaving it
290+
// alone.
288291
struct env_md_ctx_st {
289292
// digest is the underlying digest function, or NULL if not set.
290293
const EVP_MD *digest;

0 commit comments

Comments
 (0)