Update robolectric dependencies.

bcorso · Dagger Team · commit f1acd72a7ef9 · 2024-08-12T22:06:35.000-07:00
Our bazel example projects was using an old version of `bazel-robolectric` (4.1) which referenced an obsolete repository for the robolectric jars `"https://repo1.maven.org/central"`: https://github.com/robolectric/robolectric-bazel/blob/4.1/bazel/robolectric.bzl#L7 The new repository we're supposed to use is `"https://repo1.maven.org/maven2"`, which is used by `bazel-robolectric` 4.4+, e.g.: https://github.com/robolectric/robolectric-bazel/blob/4.4/bazel/robolectric.bzl#L7 This CL updates `bazel-robolectric` and all robolectric deps to 4.11.1 so that everything is using the same version. In addition, the above changes ended up breaking other tests (e.g. https://github.com/google/dagger/actions/runs/10360876140/job/28680303187), due to robolectric/robolectric#6593, and required further updating espresso to `androidx.test.espresso:espresso-core:3.5.1`. RELNOTES=N/A PiperOrigin-RevId: 662367956
diff --git a/examples/bazel/WORKSPACE b/examples/bazel/WORKSPACE
@@ -51,10 +51,13 @@ android_sdk_repository(
 
 load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 
+ROBOLECTRIC_VERSION = "4.11.1"
+
 http_archive(
     name = "robolectric",
-    strip_prefix = "robolectric-bazel-4.1",
-    urls = ["https://github.com/robolectric/robolectric-bazel/archive/4.1.tar.gz"],
+    sha256 = "1ea1cfe67848decf959316e80dd69af2bbaa359ae2195efe1366cbdf3e968356",
+    strip_prefix = "robolectric-bazel-%s" % ROBOLECTRIC_VERSION,
+    urls = ["https://github.com/robolectric/robolectric-bazel/releases/download/%s/robolectric-bazel-%s.tar.gz" % (ROBOLECTRIC_VERSION, ROBOLECTRIC_VERSION)],
 )
 
 load("@robolectric//bazel:robolectric.bzl", "robolectric_repositories")
@@ -84,8 +87,8 @@ maven_install(
         "androidx.test:runner:1.1.1",
         "com.google.truth:truth:1.0.1",
         "junit:junit:4.13",
-        "org.robolectric:robolectric:4.1",
-        "org.robolectric:annotations:4.1",
+        "org.robolectric:robolectric:%s" % ROBOLECTRIC_VERSION,
+        "org.robolectric:annotations:%s" % ROBOLECTRIC_VERSION,
     ],
     repositories = DAGGER_REPOSITORIES + HILT_ANDROID_REPOSITORIES,
 )
diff --git a/java/dagger/hilt/android/plugin/main/src/test/kotlin/IncrementalProcessorTest.kt b/java/dagger/hilt/android/plugin/main/src/test/kotlin/IncrementalProcessorTest.kt
@@ -183,7 +183,7 @@ class IncrementalProcessorTest(private val incapMode: String) {
         testImplementation 'junit:junit:4.12'
         testImplementation 'androidx.test.ext:junit:1.1.3'
         testImplementation 'androidx.test:runner:1.4.0'
-        testImplementation 'org.robolectric:robolectric:4.4'
+        testImplementation 'org.robolectric:robolectric:4.11.1'
         testImplementation 'com.google.dagger:hilt-android-testing:LOCAL-SNAPSHOT'
         testAnnotationProcessor 'com.google.dagger:hilt-compiler:LOCAL-SNAPSHOT'
       }
diff --git a/javatests/artifacts/dagger-android/simple/app/build.gradle b/javatests/artifacts/dagger-android/simple/app/build.gradle
@@ -53,18 +53,18 @@ dependencies {
   annotationProcessor 'com.google.dagger:dagger-android-processor:LOCAL-SNAPSHOT'
 
   testImplementation 'com.google.truth:truth:1.0.1'
-  testImplementation 'org.robolectric:robolectric:4.5-alpha-3'
+  testImplementation 'org.robolectric:robolectric:4.11.1'
   testImplementation 'androidx.core:core:1.3.2'
   testImplementation 'androidx.test.ext:junit:1.1.3'
   testImplementation 'androidx.test:runner:1.4.0'
-  testImplementation 'androidx.test.espresso:espresso-core:3.4.0'
+  testImplementation 'androidx.test.espresso:espresso-core:3.5.1'
   testImplementation 'com.google.dagger:dagger-compiler:LOCAL-SNAPSHOT'
   testAnnotationProcessor 'com.google.dagger:dagger-android-processor:LOCAL-SNAPSHOT'
 
   androidTestImplementation 'com.google.truth:truth:1.0.1'
   androidTestImplementation 'androidx.test.ext:junit:1.1.3'
   androidTestImplementation 'androidx.test:runner:1.4.0'
-  androidTestImplementation 'androidx.test.espresso:espresso-core:3.4.0'
+  androidTestImplementation 'androidx.test.espresso:espresso-core:3.5.1'
   androidTestImplementation 'com.google.dagger:dagger-compiler:LOCAL-SNAPSHOT'
   androidTestAnnotationProcessor 'com.google.dagger:dagger-android-processor:LOCAL-SNAPSHOT'
 
diff --git a/javatests/artifacts/dagger/lazyclasskey/app/build.gradle b/javatests/artifacts/dagger/lazyclasskey/app/build.gradle
@@ -56,7 +56,7 @@ dependencies {
     androidTestImplementation 'androidx.test.ext:junit:1.1.3'
     androidTestImplementation "androidx.test:runner:1.5.2"
     androidTestImplementation "androidx.test:rules:1.5.0"
-    androidTestImplementation 'androidx.test.espresso:espresso-core:3.4.0'
+    androidTestImplementation 'androidx.test.espresso:espresso-core:3.5.1'
 
     // Dagger dependencies
     implementation "com.google.dagger:dagger:$dagger_version"
diff --git a/javatests/artifacts/hilt-android/lazyclasskey/app/build.gradle b/javatests/artifacts/hilt-android/lazyclasskey/app/build.gradle
@@ -57,7 +57,7 @@ dependencies {
     androidTestImplementation 'androidx.test.ext:junit:1.1.3'
     androidTestImplementation "androidx.test:runner:1.5.2"
     androidTestImplementation "androidx.test:rules:1.5.0"
-    androidTestImplementation 'androidx.test.espresso:espresso-core:3.4.0'
+    androidTestImplementation 'androidx.test.espresso:espresso-core:3.5.1'
 
     // Hilt dependencies
     implementation "com.google.dagger:hilt-android:$hilt_version"
diff --git a/javatests/artifacts/hilt-android/simple/app-java-only/build.gradle b/javatests/artifacts/hilt-android/simple/app-java-only/build.gradle
@@ -61,9 +61,9 @@ dependencies {
 
   testImplementation 'com.google.truth:truth:1.0.1'
   testImplementation 'junit:junit:4.13'
-  testImplementation 'org.robolectric:robolectric:4.5-alpha-3'
+  testImplementation 'org.robolectric:robolectric:4.11.1'
   testImplementation 'androidx.core:core:1.3.2'
   testImplementation 'androidx.test.ext:junit:1.1.3'
   testImplementation 'androidx.test:runner:1.4.0'
-  testImplementation 'androidx.test.espresso:espresso-core:3.4.0'
+  testImplementation 'androidx.test.espresso:espresso-core:3.5.1'
 }
diff --git a/javatests/artifacts/hilt-android/simple/app/build.gradle b/javatests/artifacts/hilt-android/simple/app/build.gradle
@@ -108,19 +108,19 @@ dependencies {
 
   testImplementation 'com.google.truth:truth:1.0.1'
   testImplementation 'junit:junit:4.13'
-  testImplementation 'org.robolectric:robolectric:4.5-alpha-3'
+  testImplementation 'org.robolectric:robolectric:4.11.1'
   testImplementation 'androidx.core:core:1.3.2'
   testImplementation 'androidx.test.ext:junit:1.1.3'
   testImplementation 'androidx.test:runner:1.4.0'
-  testImplementation 'androidx.test.espresso:espresso-core:3.4.0'
+  testImplementation 'androidx.test.espresso:espresso-core:3.5.1'
   testImplementation "com.google.dagger:hilt-android-testing:$dagger_version"
   testAnnotationProcessor "com.google.dagger:hilt-compiler:$dagger_version"
 
   androidTestImplementation 'com.google.truth:truth:1.0.1'
   androidTestImplementation 'junit:junit:4.13'
   androidTestImplementation 'androidx.test.ext:junit:1.1.3'
   androidTestImplementation 'androidx.test:runner:1.4.0'
-  androidTestImplementation 'androidx.test.espresso:espresso-core:3.4.0'
+  androidTestImplementation 'androidx.test.espresso:espresso-core:3.5.1'
   androidTestImplementation "com.google.dagger:hilt-android-testing:$dagger_version"
   androidTestAnnotationProcessor "com.google.dagger:hilt-compiler:$dagger_version"
 
diff --git a/javatests/artifacts/hilt-android/simple/earlyentrypoint/build.gradle b/javatests/artifacts/hilt-android/simple/earlyentrypoint/build.gradle
@@ -59,7 +59,7 @@ dependencies {
 
     testImplementation 'com.google.truth:truth:1.0.1'
     testImplementation 'junit:junit:4.13'
-    testImplementation 'org.robolectric:robolectric:4.5-alpha-3'
+    testImplementation 'org.robolectric:robolectric:4.11.1'
     testImplementation 'androidx.core:core:1.3.2'
     testImplementation 'androidx.test.ext:junit:1.1.3'
     testImplementation 'androidx.test:runner:1.4.0'
diff --git a/javatests/artifacts/hilt-android/simpleKotlin/app/build.gradle b/javatests/artifacts/hilt-android/simpleKotlin/app/build.gradle
@@ -99,7 +99,7 @@ dependencies {
     testImplementation 'androidx.test:runner:1.4.0'
     testImplementation 'com.google.truth:truth:1.0.1'
     testImplementation 'junit:junit:4.13'
-    testImplementation 'org.robolectric:robolectric:4.5-alpha-3'
+    testImplementation 'org.robolectric:robolectric:4.11.1'
     testImplementation 'androidx.core:core:1.3.2'
     // TODO(bcorso): This multidex dep shouldn't be required -- it's a dep for the generated code.
     testImplementation 'androidx.multidex:multidex:2.0.0'
diff --git a/javatests/artifacts/hilt-android/viewmodel/app/build.gradle b/javatests/artifacts/hilt-android/viewmodel/app/build.gradle
@@ -57,7 +57,7 @@ dependencies {
     androidTestImplementation 'androidx.test.ext:junit:1.1.3'
     androidTestImplementation "androidx.test:runner:1.5.2"
     androidTestImplementation "androidx.test:rules:1.5.0"
-    androidTestImplementation 'androidx.test.espresso:espresso-core:3.4.0'
+    androidTestImplementation 'androidx.test.espresso:espresso-core:3.5.1'
 
     // Hilt dependencies
     implementation "com.google.dagger:hilt-android:$hilt_version"

Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,7 @@ class IncrementalProcessorTest(private val incapMode: String) {`
`183`	`183`	`testImplementation 'junit:junit:4.12'`
`184`	`184`	`testImplementation 'androidx.test.ext:junit:1.1.3'`
`185`	`185`	`testImplementation 'androidx.test:runner:1.4.0'`
`186`		`- testImplementation 'org.robolectric:robolectric:4.4'`
	`186`	`+ testImplementation 'org.robolectric:robolectric:4.11.1'`
`187`	`187`	`testImplementation 'com.google.dagger:hilt-android-testing:LOCAL-SNAPSHOT'`
`188`	`188`	`testAnnotationProcessor 'com.google.dagger:hilt-compiler:LOCAL-SNAPSHOT'`
`189`	`189`	`}`