Update HiltGradlePlugin to AGP 9. #5039
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_837566667
branch
5 times, most recently
from
f42ef5c to
1ebf530
Compare
copybara-service
bot
force-pushed
the
test_837566667
branch
from
1ebf530 to
27df0ca
Compare
This required a number of changes:
* Update Gradle 8.14.3 -> 9.2.0
* Update shadow plugin from `com.github.johnrengelman.shadow:8.1.1` to 'com.gradleup.shadow:9.2.2' (old artifact doesn't support Gradle 9).
* Update HiltGradlePlugin to 9.0.0-beta02:
* Migrate `BaseExtension` to `AndroidComponentsExtension`
* Migrate `BaseVariant` to `Component`
* Migrate `variant.javaCompileOutput.classpath` to `variant.compileClasspath`
* Migrate `variant.javaCompileOutput.destinationDirectory` to `variant.artifacts.use(HiltCopyTask).toGet()`
* Migrate `variant.javaCompileOutput.options.bootstrapClasspath` with `androidExtension.sdkComponents.bootClasspath`
* Migrate `variant.javaCompileOutput.options.compilerArgumentProviders` with `variant.javaCompilation.annotationProcessor.argumentProviders`
* `project.buildDir = ...` to `project.layout.buildDirectory.set(...)`
* Update HiltGradlePlugin tests to use AGP 9.0.0-beta02:
* Migrate to builtin kotlin
* remove 'kotlin-android'
* replace 'kotlin-kapt' with 'legacy-kapt'
* Migrate javatests/artifacts/hilt-android/simple/app/build.gradle to kts and replace GradleVersion with custom AgpVersion.
The GradleVersion does not work with APG versions like 9.0.0-beta02, so I had to do this with custom parsing.
* remove `android.kotlinOptions` (removed in AGP 9)
RELNOTES=N/A
PiperOrigin-RevId: 837566667
copybara-service
bot
force-pushed
the
test_837566667
branch
from
27df0ca to
6bf317f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update HiltGradlePlugin to AGP 9.
This required a number of changes:
com.github.johnrengelman.shadow:8.1.1to 'com.gradleup.shadow:9.2.2' (old artifact doesn't support Gradle 9).BaseExtensiontoAndroidComponentsExtensionBaseVarianttoComponentvariant.javaCompileOutput.classpathtovariant.compileClasspathvariant.javaCompileOutput.destinationDirectorytovariant.artifacts.use(HiltCopyTask).toGet()variant.javaCompileOutput.options.bootstrapClasspathwithandroidExtension.sdkComponents.bootClasspathvariant.javaCompileOutput.options.compilerArgumentProviderswithvariant.javaCompilation.annotationProcessor.argumentProvidersproject.buildDir = ...toproject.layout.buildDirectory.set(...)The GradleVersion does not work with APG versions like 9.0.0-beta02, so I had to do this with custom parsing.
android.kotlinOptions(removed in AGP 9)RELNOTES=N/A