[visibility_detector] Adapt to upcoming changes in Flutter (#480)

Author: goderbauer

.github/workflows/build.yaml

@@ -49,8 +49,8 @@ jobs:
       - name: flutter test
         run: flutter test
 
-      - name: flutter format
-        run: flutter format --dry-run --set-exit-if-changed .
+      - name: dart format
+        run: dart format -o none --set-exit-if-changed .
         # Only test formatting on one version of Flutter.
         if: ${{ matrix.version == 'stable' }}
 

packages/scrollable_positioned_list/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 0.3.8+1
+* Migrate tests off deprecated APIs.
+* Bump min Flutter version to 3.1.0.
+
 # 0.3.8
 * Add ScrollOffsetController to allow pixel-based changes in offset.
 * Bump min sdk version to 2.15.0

packages/scrollable_positioned_list/example/test/scrollable_positioned_list_example_test.dart

@@ -3,16 +3,18 @@
 // found in the LICENSE file.
 
 import 'package:flutter/material.dart';
-import 'package:flutter/rendering.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:scrollable_positioned_list/scrollable_positioned_list.dart';
 
 import 'package:scrollable_positioned_list_example/main.dart';
 
 void main() {
   setUp(() {
-    WidgetsBinding.instance.renderView.configuration = TestViewConfiguration(
-        size: const Size(800, 900), window: RendererBinding.instance.window);
+    WidgetsBinding.instance.renderView.configuration =
+        TestViewConfiguration.fromView(
+      size: const Size(800, 900),
+      view: WidgetsBinding.instance.platformDispatcher.views.single,
+    );
   });
 
   testWidgets('Start at 0', (WidgetTester tester) async {

packages/scrollable_positioned_list/pubspec.yaml

@@ -1,12 +1,12 @@
 name: scrollable_positioned_list
-version: 0.3.8
+version: 0.3.8+1
 description: >
   A list with helper methods to programmatically scroll to an item.
 homepage: https://github.com/google/flutter.widgets/tree/master/packages/scrollable_positioned_list
 
 environment:
   sdk: '>=2.15.0 <4.0.0'
-  flutter: '>=2.12.0'
+  flutter: '>=3.1.0'
 
 dependencies:
   flutter:

packages/scrollable_positioned_list/test/horizontal_scrollable_positioned_list_test.dart

@@ -22,9 +22,8 @@ void main() {
     EdgeInsets? padding,
     int initialScrollIndex = 0,
   }) async {
-    tester.binding.window.devicePixelRatioTestValue = 1.0;
-    tester.binding.window.physicalSizeTestValue =
-        const Size(screenWidth, screenHeight);
+    tester.view.devicePixelRatio = 1.0;
+    tester.view.physicalSize = const Size(screenWidth, screenHeight);
 
     await tester.pumpWidget(
       MaterialApp(

packages/scrollable_positioned_list/test/positioned_list_test.dart

@@ -24,9 +24,8 @@ void main() {
     double anchor = 0,
     int itemCount = defaultItemCount,
   }) async {
-    tester.binding.window.devicePixelRatioTestValue = 1.0;
-    tester.binding.window.physicalSizeTestValue =
-        const Size(screenWidth, screenHeight);
+    tester.view.devicePixelRatio = 1.0;
+    tester.view.physicalSize = const Size(screenWidth, screenHeight);
 
     await tester.pumpWidget(
       MaterialApp(

packages/scrollable_positioned_list/test/reversed_positioned_list_test.dart

@@ -23,9 +23,8 @@ void main() {
     double anchor = 0,
     int itemCount = defaultItemCount,
   }) async {
-    tester.binding.window.devicePixelRatioTestValue = 1.0;
-    tester.binding.window.physicalSizeTestValue =
-        const Size(screenWidth, screenHeight);
+    tester.view.devicePixelRatio = 1.0;
+    tester.view.physicalSize = const Size(screenWidth, screenHeight);
 
     await tester.pumpWidget(
       MaterialApp(

packages/scrollable_positioned_list/test/reversed_scrollable_positioned_list_test.dart

@@ -21,9 +21,8 @@ void main() {
     EdgeInsets? padding,
     int initialIndex = 0,
   }) async {
-    tester.binding.window.devicePixelRatioTestValue = 1.0;
-    tester.binding.window.physicalSizeTestValue =
-        const Size(screenWidth, screenHeight);
+    tester.view.devicePixelRatio = 1.0;
+    tester.view.physicalSize = const Size(screenWidth, screenHeight);
 
     await tester.pumpWidget(
       MaterialApp(

packages/scrollable_positioned_list/test/scroll_offset_controller_test.dart

@@ -37,9 +37,8 @@ void main() {
     double? minCacheExtent,
     bool variableHeight = false,
   }) async {
-    tester.binding.window.devicePixelRatioTestValue = 1.0;
-    tester.binding.window.physicalSizeTestValue =
-        const Size(screenWidth, screenHeight);
+    tester.view.devicePixelRatio = 1.0;
+    tester.view.physicalSize = const Size(screenWidth, screenHeight);
 
     await tester.pumpWidget(
       MaterialApp(

packages/scrollable_positioned_list/test/scroll_offset_listener_test.dart

@@ -36,9 +36,8 @@ void main() {
     double? minCacheExtent,
     bool variableHeight = false,
   }) async {
-    tester.binding.window.devicePixelRatioTestValue = 1.0;
-    tester.binding.window.physicalSizeTestValue =
-        const Size(screenWidth, screenHeight);
+    tester.view.devicePixelRatio = 1.0;
+    tester.view.physicalSize = const Size(screenWidth, screenHeight);
 
     await tester.pumpWidget(
       MaterialApp(