Skip to content
This repository was archived by the owner on Oct 20, 2022. It is now read-only.
This repository was archived by the owner on Oct 20, 2022. It is now read-only.

python build scripts don't escape paths on Windows #3

@aardappel

Description

@aardappel

Running with "-d @ -r" on Windows, I get the output:

BUILD SUCCESSFUL
Total time: 4 seconds
Subprocess returned 1
Traceback (most recent call last):
  File "build_all_android.py", line 212, in <module>
    sys.exit(main())
  File "build_all_android.py", line 171, in main
    adb_devices = [d.serial for d in env.get_adb_devices()]
  File "C:\w\lobster\dev\android\buildutil\android.py", line 1182, in get_adb_devices
    capture=True, shell=True)[0]
  File "C:\w\lobster\dev\android\buildutil\common.py", line 470, in run_subprocess
    raise SubCommandError(argv, process.returncode, stderr)
buildutil.common.SubCommandError: Error 1 running C as: C:\Program Files (x86)\Android\android-sdk\platform-tools\adb.exe devices -l, stderr: {'C:\Program' is not recognized as an internal or external command,
operable program or batch file.
}

Appears it should be quoting paths somewhere.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions