You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jan 10, 2023. It is now read-only.
TypeError: Cannot read property '1' of undefined
at Cell.renderAirwire (/home/amstan/Projects/netlistsvg/built/Cell.js:443:22)
at /home/amstan/Projects/netlistsvg/built/Cell.js:338:23
at Array.forEach (<anonymous>)
at Cell.render (/home/amstan/Projects/netlistsvg/built/Cell.js:327:30)
at /home/amstan/Projects/netlistsvg/built/drawModule.js:25:18
at Array.map (<anonymous>)
at Object.drawModule [as default] (/home/amstan/Projects/netlistsvg/built/drawModule.js:23:30)
at /home/amstan/Projects/netlistsvg/built/index.js:57:61
Looks like netlistsvg.py also outputs the json wrong for LEDs, even though netlistsvg will render it as a generic, we still output it as if it puts a skinned JellyBean (with pins named A and B). My netlistsvg modifications aren't reliable enough and it crashes when it looks a pin name and pin number syntax and doesn't find any because it's a generic.
The text was updated successfully, but these errors were encountered:
LEDs, Diodes and Inductors get better representation now.
Mitigates a little Issue #27
TEST=Try snippet from Issue #27; don't see netlistsvg crash anymore, but see a nice LED
TEST=servo_micro now has an inductor in the svg
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Thanks Alan for finding this!
For the following test file:
You might get an error with the current https://github.com/amstan/netlistsvg/tree/for-pcbdl:
This is due to this line: https://github.com/amstan/netlistsvg/blob/for-pcbdl/lib/Cell.ts#L464
Problems don't end there:
Looks like netlistsvg.py also outputs the json wrong for LEDs, even though netlistsvg will render it as a generic, we still output it as if it puts a skinned JellyBean (with pins named A and B). My netlistsvg modifications aren't reliable enough and it crashes when it looks a pin name and pin number syntax and doesn't find any because it's a generic.
The text was updated successfully, but these errors were encountered: