Fix all ty errors

Author: dbieber

.github/scripts/build.sh

@@ -27,5 +27,5 @@ pylint fire --ignore=test_components_py3.py,parser_fuzz_test.py,console
 if [[ ${PYTHON_VERSION} == 3.12 ]]; then
   # Run type-checking
   pip install uv
-  uvx ty check --exclude fire/test_components_py3.py
+  uvx ty check --exclude fire/test_components_py3.py --exclude fire/console/ --exclude fire/formatting_windows.py
 fi

fire/console/console_attr_os.py

@@ -73,7 +73,7 @@ def _GetXY(fd):
     try:
       # This magic incantation converts a struct from ioctl(2) containing two
       # binary shorts to a (rows, columns) int tuple.
-      rc = struct.unpack(b'hh', fcntl.ioctl(fd, termios.TIOCGWINSZ, 'junk'))
+      rc = struct.unpack(b'hh', fcntl.ioctl(fd, termios.TIOCGWINSZ, b'junk'))
       return (rc[1], rc[0]) if rc else None
     except:  # pylint: disable=bare-except
       return None

fire/helptext.py

@@ -87,9 +87,10 @@ def HelpText(component, trace=None, verbose=False):
       + usage_details_sections
       + notes_sections
   )
+  valid_sections = [section for section in sections if section is not None]
   return '\n\n'.join(
-      _CreateOutputSection(*section)
-      for section in sections if section is not None
+      _CreateOutputSection(name, content)
+      for name, content in valid_sections
   )
 
 
@@ -283,7 +284,7 @@ def _ArgsAndFlagsSections(info, spec, metadata):
   return args_and_flags_sections, notes_sections
 
 
-def _UsageDetailsSections(component, actions_grouped_by_kind):
+def _UsageDetailsSections(component, actions_grouped_by_kind) -> list[tuple[str, str]]:
   """The usage details sections of the help string."""
   groups, commands, values, indexes = actions_grouped_by_kind
 

pyproject.toml

@@ -63,6 +63,3 @@ addopts = [
     "--ignore=fire/test_components_py3.py",
     "--ignore=fire/parser_fuzz_test.py"
 ]
-
-[tool.ty]
-# ty configuration - using defaults for now