-
Notifications
You must be signed in to change notification settings - Fork 138
Consider removing raw JSON data from error messages #661
Copy link
Copy link
Open
Labels
api:gemini-apiIssues related to Gemini APIIssues related to Gemini APIpriority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Metadata
Metadata
Assignees
Labels
api:gemini-apiIssues related to Gemini APIIssues related to Gemini APIpriority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
I wanted to propose removing raw JSON from error messages, particularly in the cases of JSON unmarshalling errors. From a client point of view, if the server returned invalid JSON, the only action we can take is open a support case. I don't believe knowing the details of the JSON is something that would help on the client side, but it does expose our sensitive response data in our logs, requiring effort to sanitize errors from the SDK before we send them to stdout.