Skip to content

GenerateImagesConfig AddWatermark should be present always #714

@sousandrei

Description

@sousandrei

AddWatermark currently has omitempty, which in turns makes so that the API is called without the field set to false. Since the watermarks are enable by default, there is no way we can disable it in the config

This is specially problematic if you call it with a seed for example. Some models do not support having a watermark together with a seed.

Environment details

  • Programming language: golang
  • OS: macos
  • Language runtime version: 1.26
  • Package version: 1.49

Steps to reproduce

  1. set GenerateImagesConfig.AddWatermark to false
  2. observe as your config is ignored by the api call

Metadata

Metadata

Labels

api:gemini-apiIssues related to Gemini APIpriority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions