From 7ac2362e59ae0494da5d2aedc51b35cc00ca35ee Mon Sep 17 00:00:00 2001
From: ClaytonNorthey92 <clayton.northey@gmail.com>
Date: Tue, 25 Nov 2025 16:14:50 -0500
Subject: [PATCH] refactor: cleanup redundancies in actions workflow

update the .workflows/test.yml file to remove (most) redudancies

in the .workflows/test.yml file...
* add matrix entries for go versions 1.23, 1.24
* add matrix entries for each "latest" os (macos, linux, windows)
* use this matrix for both testing and linting, but keep jobs separate
* update golangci-lint timeout to 120s as it was timing out on windows
---
 .github/workflows/test.yml | 103 ++++++-------------------------------
 1 file changed, 15 insertions(+), 88 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 7011e5d8..dd0e4b67 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -7,94 +7,17 @@ on:
     branches:
       - main
 jobs:
-  go_tests_latest:
-    runs-on: windows-latest
+  go_unit_tests:
+    strategy:
+      matrix:
+        go-version: [1.23, 1.24]
+        runs-on: [windows-latest, macos-latest, ubuntu-latest]
+    runs-on: ${{ matrix.runs-on }}
     steps:
       - name: Install Go
         uses: actions/setup-go@v5
         with:
-          go-version: 1.24
-
-      - name: Check out code into the Go module directory
-        uses: actions/checkout@v4
-
-      - name: Run vet
-        run: go vet ./...
-
-      - name: Test
-        run: go test --mode=unit -v ./...
-  # go_tests_mac_latest:
-  #   runs-on: macos-latest
-  #   steps:
-  #     - name: Install Go
-  #       uses: actions/setup-go@v5
-  #       with:
-  #         go-version: 1.24
-
-  #     - name: Check out code into the Go module directory
-  #       uses: actions/checkout@v4
-
-  #     - name: Run vet
-  #       run: go vet ./...
-
-  #     - name: Test
-  #       run: go test --mode=unit -v ./...
-  go_tests_linux_latest:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Install Go
-        uses: actions/setup-go@v5
-        with:
-          go-version: 1.24
-
-      - name: Check out code into the Go module directory
-        uses: actions/checkout@v4
-
-      - name: Run vet
-        run: go vet ./...
-
-      - name: Test
-        run: go test --mode=unit -v ./...
-  go_tests:
-    runs-on: windows-latest
-    steps:
-      - name: Install Go
-        uses: actions/setup-go@v5
-        with:
-          go-version: 1.23
-
-      - name: Check out code into the Go module directory
-        uses: actions/checkout@v4
-
-      - name: Run vet
-        run: go vet ./...
-
-      - name: Test
-        run: go test --mode=unit -v ./...
-  go_tests_mac:
-    # TODO: Change to macos-latest once hanging issue is resolved.
-    runs-on: ubuntu-latest
-    steps:
-      - name: Install Go
-        uses: actions/setup-go@v5
-        with:
-          go-version: 1.23
-
-      - name: Check out code into the Go module directory
-        uses: actions/checkout@v4
-
-      - name: Run vet
-        run: go vet ./...
-
-      - name: Test
-        run: go test --mode=unit -v ./...
-  go_tests_linux:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Install Go
-        uses: actions/setup-go@v5
-        with:
-          go-version: 1.23
+          go-version: ${{ matrix.go-version }}
 
       - name: Check out code into the Go module directory
         uses: actions/checkout@v4
@@ -105,16 +28,20 @@ jobs:
       - name: Test
         run: go test --mode=unit -v ./...
   lint:
-    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        go-version: [1.23, 1.24]
+        runs-on: [windows-latest, macos-latest, ubuntu-latest]
+    runs-on: ${{ matrix.runs-on }}
     steps:
       - name: Setup go
         uses: actions/setup-go@v4
         with:
-          go-version: '1.23'
+          go-version: ${{ matrix.go-version }}
       - name: Checkout repository
         uses: actions/checkout@v3
-      - name: Setup golangci-lint
+      - name: Setup and run golangci-lint
         uses: golangci/golangci-lint-action@v3
         with:
           version: latest
-          args: --max-same-issues 0 --out-format colored-line-number --exclude-dirs=examples
+          args: --timeout 120s --max-same-issues 0 --out-format colored-line-number --exclude-dirs=examples