Skip to content

Commit 9ee9246

Browse files
committed
chore: Add junit4 to ignore in dependency check
1 parent 07dafe0 commit 9ee9246

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

pom.xml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -408,12 +408,14 @@
408408
<groupId>org.apache.maven.plugins</groupId>
409409
<artifactId>maven-dependency-plugin</artifactId>
410410
<configuration>
411-
<!-- This dependency is still declared even though tests are migrated to JUnit 5. -->
412-
<!-- failsafe plugin pulls in surefire-platform-47 dep from shared-config to run the ITs. -->
413-
<!-- It runs the ITs with JUnit4 and until that is removed upstream, we need to decare it -->
414-
<ignoredUnusedDeclaredDependencies>junit:junit</ignoredUnusedDeclaredDependencies>
415-
<!-- maven-dependency-plugin cannot detect the runtime usage of junit-jupiter-engine for executing JUnit 5+ tests. -->
416-
<ignoredUnusedDeclaredDependencies>org.junit.jupiter:junit-jupiter-engine</ignoredUnusedDeclaredDependencies>
411+
<ignoredUnusedDeclaredDependencies>
412+
<!-- This dependency is still declared even though tests are migrated to JUnit 5. -->
413+
<!-- failsafe plugin pulls in surefire-platform-47 dep from shared-config to run the ITs. -->
414+
<!-- It runs the ITs with JUnit4 and until that is removed upstream, we need to decare it -->
415+
<ignoredUnusedDeclaredDependency>junit:junit</ignoredUnusedDeclaredDependency>
416+
<!-- maven-dependency-plugin cannot detect the runtime usage of junit-jupiter-engine for executing JUnit 5+ tests. -->
417+
<ignoredUnusedDeclaredDependency>org.junit.jupiter:junit-jupiter-engine</ignoredUnusedDeclaredDependency>
418+
</ignoredUnusedDeclaredDependencies>
417419
</configuration>
418420
</plugin>
419421
</plugins>

0 commit comments

Comments
 (0)