datastore: fix panic when filtering with nil value #13541
Conversation
The datastore client previously panicked when a query filter used an untyped nil value (e.g., `q.FilterField("Field", "=", nil)`). This was caused by an unnecessary use of `reflect.ValueOf(pf.Value).Interface()`, which panics on zero Values (derived from untyped nil).
This change removes the redundant reflection call, passing the value directly to `interfaceToProto`, which correctly handles nil inputs.
Fixes #13499
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
product-auto-label
bot
added
the
api: datastore
Fix panic in datastore client when filtering with nil value.
PR created automatically by Jules for task 8212118389976629891 started by @bhshkh