Skip to content

Comments

feat(firestore): add pipeline string expressions#2479

Open
dlarocque wants to merge 3 commits intomainfrom
dl/string-expressions
Open

feat(firestore): add pipeline string expressions#2479
dlarocque wants to merge 3 commits intomainfrom
dl/string-expressions

Conversation

@dlarocque
Copy link
Contributor

@dlarocque dlarocque commented Feb 6, 2026

Adds the ltrim, rttrim, stringIndexOf, stringReplaceOne, stringReplaceAll, stringRepeat Pipeline expressions.

@dlarocque
feat(firestore): add pipeline string expressions
449a02d 
Adds the `ltrim`, `rttrim`, `stringIndexOf`, `stringReplaceOne`, `stringReplaceAll`, `stringRepeat` Pipeline expressions.
@dlarocque dlarocque requested review from a team as code owners February 6, 2026 16:34
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Feb 6, 2026
milaGGL
milaGGL reviewed Feb 9, 2026
View reviewed changes
milaGGL
milaGGL reviewed Feb 9, 2026
View reviewed changes
milaGGL
milaGGL reviewed Feb 9, 2026
View reviewed changes
milaGGL
milaGGL reviewed Feb 9, 2026
View reviewed changes
milaGGL
milaGGL reviewed Feb 9, 2026
View reviewed changes
Copy link
Contributor

@milaGGL milaGGL left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add changelog for this pr as well

dlarocque
dlarocque commented Feb 11, 2026
View reviewed changes
Copy link
Contributor Author

@dlarocque dlarocque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@milaGGL I added some more test cases.

Where do I update the changelog? I didn't do that for my previous PR #2474

My understanding is that our tooling automatically sets the changelog entry to be the name and link of a PR

@dlarocque dlarocque requested a review from milaGGL February 11, 2026 15:23
@milaGGL
Copy link
Contributor

milaGGL commented Feb 11, 2026

Where do I update the changelog? I didn't do that for my previous PR #2474
My understanding is that our tooling automatically sets the changelog entry to be the name and link of a PR

I misremembered it. u r right, no need to manually update the CHANGELOG for this repo.

@dlarocque dlarocque assigned milaGGL and unassigned MarkDuckworth Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarkDuckworth MarkDuckworth Awaiting requested review from MarkDuckworth

@milaGGL milaGGL Awaiting requested review from milaGGL

At least 1 approving review is required to merge this pull request.

Assignees

@milaGGL milaGGL

Labels

api: firestore Issues related to the googleapis/nodejs-firestore API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dlarocque @milaGGL @MarkDuckworth