Refactor

Author: vinceatbluelabs

pybigquery/sqlalchemy_bigquery.py

@@ -363,13 +363,15 @@ def _split_table_name(full_table_name):
             dataset, table_name = table_name_split
         elif len(table_name_split) == 3:
             project, dataset, table_name = table_name_split
+        # TODO: Get a test for an else statement here
 
         return (project, dataset, table_name)
 
     def _table_reference(self, provided_schema_name, provided_table_name,
                          client_project):
         project_id_from_table, dataset_id_from_table, table_id = self._split_table_name(provided_table_name)
         project_id_from_schema = None
+        dataset_id_from_schema = None
         if provided_schema_name is not None:
             provided_schema_name_split = provided_schema_name.split('.')
             if len(provided_schema_name_split) == 0:
@@ -378,12 +380,12 @@ def _table_reference(self, provided_schema_name, provided_table_name,
                 if dataset_id_from_table:
                     project_id_from_schema = provided_schema_name_split[0]
                 else:
-                    pass  # TODO: write a test case
+                    dataset_id_from_schema = provided_schema_name_split[0]
             elif len(provided_schema_name_split) == 2:
                 pass
             # TODO: Get a test for an else statement here
         project_id = project_id_from_schema or project_id_from_table or client_project
-        dataset_id = dataset_id_from_table or provided_schema_name or self.dataset_id
+        dataset_id = dataset_id_from_schema or dataset_id_from_table or self.dataset_id
 
         table_ref = TableReference.from_string("{}.{}.{}".format(
             project_id, dataset_id, table_id