Skip to content

Commit 2cf05a0

Browse files
author
Jim Fulton
authored
fix: dialect atribute wasn't provided (#291)
1 parent b1fdeae commit 2cf05a0

File tree

3 files changed

+10
-1
lines changed

3 files changed

+10
-1
lines changed

sqlalchemy_bigquery/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
from .version import __version__ # noqa
2424

25-
from .base import BigQueryDialect
25+
from .base import BigQueryDialect, dialect # noqa
2626
from .base import (
2727
STRING,
2828
BOOL,

sqlalchemy_bigquery/base.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -986,6 +986,8 @@ def get_view_definition(self, connection, view_name, schema=None, **kw):
986986
return view.view_query
987987

988988

989+
dialect = BigQueryDialect
990+
989991
try:
990992
import alembic # noqa
991993
except ImportError:

tests/unit/test_sqlalchemy_bigquery.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,3 +171,10 @@ def test_multi_value_insert(faux_conn, last_query):
171171
" (%(id_m0:INT64)s), (%(id_m1:INT64)s), (%(id_m2:INT64)s)",
172172
{"id_m0": 0, "id_m1": 1, "id_m2": 2},
173173
)
174+
175+
176+
def test_follow_dialect_attribute_convention():
177+
import sqlalchemy_bigquery.base
178+
179+
assert sqlalchemy_bigquery.dialect is sqlalchemy_bigquery.BigQueryDialect
180+
assert sqlalchemy_bigquery.base.dialect is sqlalchemy_bigquery.BigQueryDialect

0 commit comments

Comments
 (0)