Skip to content

Commit 68afc39

Browse files
committed
test basic implementation of group_by_clause and visit_label
1 parent ece7f1f commit 68afc39

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

sqlalchemy_bigquery/base.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
import sqlalchemy
3939
import sqlalchemy.sql.expression
4040
import sqlalchemy.sql.functions
41-
from sqlalchemy.sql.functions import rollup, cube, grouping_sets
4241
import sqlalchemy.sql.sqltypes
4342
import sqlalchemy.sql.type_api
4443
from sqlalchemy.exc import NoSuchTableError, NoSuchColumnError
@@ -333,13 +332,7 @@ def visit_column(
333332

334333
return self.preparer.quote(tablename) + "." + name
335334

336-
def visit_label(self, *args, within_group_by=False, **kwargs):
337-
# Use labels in GROUP BY clause.
338-
#
339-
# Flag set in the group_by_clause method. Works around missing
340-
# equivalent to supports_simple_order_by_label for group by.
341-
if within_group_by:
342-
kwargs["render_label_as_label"] = args[0]
335+
def visit_label(self, *args, **kwargs):
343336
return super(BigQueryCompiler, self).visit_label(*args, **kwargs)
344337

345338
def group_by_clause(self, select, **kwargs):

0 commit comments

Comments
 (0)