Skip to content

Commit e95aee1

Browse files
committed
cleaned up code from review, removed unnecessary code and files
1 parent 1e54e77 commit e95aee1

File tree

3 files changed

+0
-23
lines changed

3 files changed

+0
-23
lines changed

sqlalchemy_bigquery/test.py

Lines changed: 0 additions & 10 deletions
This file was deleted.

tests/sqlalchemy_dialect_compliance/test_dialect_compliance.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,6 @@ def literal(value, type_=None):
8585
if type_ is not None:
8686
assert type_ is self.datatype
8787

88-
import sqlalchemy.sql.sqltypes
89-
9088
return sqlalchemy.sql.elements.literal(value, self.datatype)
9189

9290
with mock.patch("sqlalchemy.testing.suite.test_types.literal", literal):
@@ -127,7 +125,6 @@ def test_update(self):
127125
# Had to pass in data as a dict object in 2.0
128126
r = connection.execute(t.update().where(t.c.id == 2), dict(data="d2_new"))
129127
assert not r.is_insert
130-
# assert not r.returns_rows
131128

132129
eq_(
133130
connection.execute(t.select().order_by(t.c.id)).fetchall(),
@@ -139,7 +136,6 @@ def test_delete(self):
139136
connection = config.db.connect()
140137
r = connection.execute(t.delete().where(t.c.id == 2))
141138
assert not r.is_insert
142-
# assert not r.returns_rows
143139
eq_(
144140
connection.execute(t.select().order_by(t.c.id)).fetchall(),
145141
[(1, "d1"), (3, "d3")],
@@ -526,7 +522,6 @@ def test_update(self):
526522
t = self.tables.plain_pk
527523
r = config.db.execute(t.update().where(t.c.id == 2), data="d2_new")
528524
assert not r.is_insert
529-
# assert not r.returns_rows
530525

531526
eq_(
532527
config.db.execute(t.select().order_by(t.c.id)).fetchall(),
@@ -537,7 +532,6 @@ def test_delete(self):
537532
t = self.tables.plain_pk
538533
r = config.db.execute(t.delete().where(t.c.id == 2))
539534
assert not r.is_insert
540-
# assert not r.returns_rows
541535
eq_(
542536
config.db.execute(t.select().order_by(t.c.id)).fetchall(),
543537
[(1, "d1"), (3, "d3")],
@@ -671,7 +665,6 @@ def test_update(self):
671665
t = self.tables.plain_pk
672666
r = config.db.execute(t.update().where(t.c.id == 2), data="d2_new")
673667
assert not r.is_insert
674-
# assert not r.returns_rows
675668

676669
eq_(
677670
config.db.execute(t.select().order_by(t.c.id)).fetchall(),
@@ -682,7 +675,6 @@ def test_delete(self):
682675
t = self.tables.plain_pk
683676
r = config.db.execute(t.delete().where(t.c.id == 2))
684677
assert not r.is_insert
685-
# assert not r.returns_rows
686678
eq_(
687679
config.db.execute(t.select().order_by(t.c.id)).fetchall(),
688680
[(1, "d1"), (3, "d3")],

tests/system/test_sqlalchemy_bigquery.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -286,11 +286,6 @@ def test_reflect_select(table, engine_using_test_dataset, table_using_test_datas
286286
assert isinstance(table.c["nested_record.record.name"].type, types.String)
287287
assert isinstance(table.c.array.type, types.ARRAY)
288288

289-
# Force unique column labels using `use_labels` below to deal
290-
# with BQ sometimes complaining about duplicate column names
291-
# when a destination table is specified, even though no
292-
# destination table is specified. When this test was written,
293-
# `use_labels` was forced by the dialect.
294289
with engine_using_test_dataset.connect() as conn:
295290
rows = conn.execute(
296291
table.select().set_label_style(

0 commit comments

Comments
 (0)