removed unnecessary clause function changes, edited tests

Author: kiraksi

sqlalchemy_bigquery/base.py

@@ -342,37 +342,8 @@ def visit_label(self, *args, within_group_by=False, **kwargs):
             kwargs["render_label_as_label"] = args[0]
         return super(BigQueryCompiler, self).visit_label(*args, **kwargs)
 
-    def group_by_clause(self, select, **kw):
-        grouping_sets_exprs = []
-        rollup_exprs = []
-        cube_exprs = []
-
-        # Traverse select statement to extract grouping sets, rollup, and cube expressions
-        for expr in select._group_by_clause:
-            if isinstance(expr, grouping_sets):
-                grouping_sets_exprs.append(
-                    self.process(expr.clauses)
-                )  # Assuming SQLAlchemy syntax
-            elif isinstance(expr, rollup):  # Assuming SQLAlchemy syntax
-                rollup_exprs.append(self.process(expr.clauses))
-            elif isinstance(expr, cube):  # Assuming SQLAlchemy syntax
-                cube_exprs.append(self.process(expr.clauses))
-            else:
-                # Handle regular group by expressions
-                pass
-
-        clause = super(BigQueryCompiler, self).group_by_clause(select, **kw)
-
-        if grouping_sets_exprs:
-            clause = (
-                f"GROUP BY {clause} GROUPING SETS ({', '.join(grouping_sets_exprs)})"
-            )
-        if rollup_exprs:
-            clause = f"GROUP BY {clause} ROLLUP ({', '.join(rollup_exprs)})"
-        if cube_exprs:
-            clause = f"GROUP BY {clause} CUBE ({', '.join(cube_exprs)})"
-
-        return clause
+    def group_by_clause(self, select, **kwargs):
+        return super(BigQueryCompiler, self).group_by_clause(select, **kwargs)
 
     ############################################################################
     # Handle parameters in in

testing/constraints-3.8.txt

@@ -3,7 +3,7 @@
 # List *all* library dependencies and extras in this file.
 # Pin the version to the lower bound.
 #
-# e.g., if setup.py has "foo >= 1.14.1, < 2.0.0dev",
+# e.g., if setup.py has "foo >= 1.14.0, < 2.0.0dev",
 sqlalchemy==1.4.16
 google-auth==1.25.0
 google-cloud-bigquery==3.3.6

tests/unit/test_compiler.py

@@ -297,7 +297,7 @@ def test_grouping_sets(faux_conn, metadata):
 
     expected_sql = (
         "SELECT `table1`.`foo`, `table1`.`bar` \n"
-        "FROM `table1` GROUP BY GROUPING SETS ((`table1`.`foo`), (`table1`.`bar`))"
+        "FROM `table1` GROUP BY GROUPING SETS(`table1`.`foo`, `table1`.`bar`)"
     )
     found_sql = q.compile(faux_conn).string
     assert found_sql == expected_sql