add-shopping-cart does not work when vulcanised?

[gertcuykens]

Is there something special about that icon?

Example:
https://github.com/gertcuykens/sea-is-snow/blob/master/default/catalog1.html#L205

This does not work when you vulcanise the site?

[robdodson]

I think you mean to link to this line:
https://github.com/gertcuykens/sea-is-snow/blob/master/default/catalog1.html#L205

Does the icon disappear when you vulcanize? That seems odd

[gertcuykens]

Yes you are correct, it disappears when vulcanize. The other one does not. Just replace the line and you wil see no icons on the beanie page in the vulcanised version. You will only see does add-shopping-cart icons when it is not vulcanised. I included a gulpfile that runs a appengine so you can easily build and reproduce. PS Hold on I will see if I can host two builds to show you.

[gertcuykens]

http://sea-is-snow.appspot.com/build.html (add icon)
http://sea-is-snow.appspot.com/build1.html (add-shopping-cart icon)
(click the beanies page-tab)

[robdodson]

In both of the links you provided I see the shopping cart in the top left

On Sat, Oct 11, 2014 at 11:26 AM, Gert Cuykens notifications@github.com
wrote:

http://sea-is-snow.appspot.com/build.html
http://sea-is-snow.appspot.com/build1.html

—
Reply to this email directly or view it on GitHub
#24 (comment).

[gertcuykens]

yes that one is ok. It are the other ones in the blue circles (see screenshots) on the beanie tab. The one on the top left is a shopping-cart icon. Its a different one then add-shopping-cart

[robdodson]

oh sorry, I didn't see the screenshot in my email. Let me take another look :)

[robdodson]

testing on a local app, I ran vulcanize --csp --inline --strip and was not
able to reproduce this error. Do you see the same issue if you create an
app that just has a paper-fab inside of it and nothing else? I wouldn't be
surprised if there was a bug in vulcanize but you may need to remove parts
of the app to figure out which piece is tripping up vulcanize

On Sun, Oct 12, 2014 at 5:13 PM, Gert Cuykens notifications@github.com
wrote:

yes that one is ok. It are the other ones in the blue circles (see
screenshot)

—
Reply to this email directly or view it on GitHub
#24 (comment).

[gertcuykens]

Ok going to do that, ps on http://sea-is-snow.appspot.com/build1.html do you see the same thing as in the screenshot? (empty blue circles) Just to be sure its not a chrome thing or something?

[robdodson]

Yep I was seeing the same thing in your live site, but wasn't able to reproduce it with a local, vulvanized page that just had a few divs and a paper-fab

[gertcuykens]

Ok now I really have narrowed it down to just a few lines :D

http://sea-is-snow.appspot.com/test.html (icon)
http://sea-is-snow.appspot.com/testB.html (no-icon)

https://github.com/gertcuykens/sea-is-snow/blob/master/default/test.html
https://github.com/gertcuykens/sea-is-snow/blob/master/default/testB.html

vulcanize -o default/testB.html default/test.html --inline --strip

PS I did sudo npm update -g first so I guess i have the latest vulcanize?

[robdodson]

The definition for the icon looks like it's present in the testB.html file. @azakus any idea what may be going wrong?

[gertcuykens]

Same result when using just <core-icon icon="add-shopping-cart"></core-icon> directly instead of paper-fab

http://sea-is-snow.appspot.com/test.html (icon)
http://sea-is-snow.appspot.com/testB.html (no-icon)

https://github.com/gertcuykens/sea-is-snow/blob/master/default/test.html
https://github.com/gertcuykens/sea-is-snow/blob/master/default/testB.html

vulcanize -o default/testB.html default/test.html --inline --strip

[robdodson]

@gertcuykens could you run the following command npm ls -g --defs=0 and search for vulcanize to let me know which version you're running

[dfreedm]

Hmm, looks like this isn't fixed in newer versions of vulcanize :(. However, the next batch of core-icons updates does work correctly. This will be in the next release.

As a side note, I'm pretty hopeful that using a more spec compliant html processing library ( https://github.com/Polymer/vulcanize/issues/73) will fix some of these bizarre issues.

[gertcuykens]

vulcanize 0.4.3