Skip to content

fix: #23, support hiden interface #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: #23, support hiden interface #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 37 additions & 7 deletions compiler/prelude/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ var $methodSet = function(typ) {
var current = [{typ: isPtr ? typ.elem : typ, indirect: isPtr}];

var seen = {};

var depth = 0;
while (current.length > 0) {
var next = [];
var mset = [];
Expand All @@ -420,9 +420,17 @@ var $methodSet = function(typ) {
seen[e.typ.string] = true;

if (e.typ.named) {
mset = mset.concat(e.typ.methods);
var methods = []
e.typ.methods.forEach(function(m) {
methods.push({m:m, typ: $kindStruct, depth:depth});
})
mset = mset.concat(methods);
if (e.indirect) {
mset = mset.concat($ptrType(e.typ).methods);
var methods = [];
$ptrType(e.typ).methods.forEach(function(m) {
methods.push({m:m, typ: $kindStruct, depth: depth});
})
mset = mset.concat(methods);
}
}

Expand All @@ -438,23 +446,45 @@ var $methodSet = function(typ) {
break;

case $kindInterface:
mset = mset.concat(e.typ.methods);
var methods = [];
e.typ.methods.forEach(function(m) {
methods.push({m:m, typ: $kindInterface, depth: depth});
})
mset = mset.concat(methods);
break;
}
});

mset.forEach(function(m) {
mset.forEach(function(item) {
var m = item.m, typ = item.typ;
if (base[m.name] === undefined) {
base[m.name] = m;
base[m.name] = [item];
} else {
base[m.name].push(item);
}
});

depth++;
current = next;
}

var illegal = {};
Object.keys(base).forEach(function(name) {
var items = base[name];
var depth = items[0].depth;
var length = items.length;
for(var i=1; i<length; i++) {
if (depth === items[i].depth) {
illegal[name] = true;
}
}
})

typ.methodSetCache = [];
Object.keys(base).sort().forEach(function(name) {
typ.methodSetCache.push(base[name]);
if (illegal[name] === undefined) {
typ.methodSetCache.push(base[name][0].m);
}
});
return typ.methodSetCache;
};
Expand Down