-
Notifications
You must be signed in to change notification settings - Fork 10
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Description
It seems like temps has some git commands wrong which result in an error on repo checkout.
Steps to reproduce
- Create project using
bentopdfpublic repo as a source: https://github.com/alam00000/bentopdf - Start deployment
Expected behavior
Service is successfully deployed by Temps.
Actual behavior
Public repo checkout results in an error.
Cancellation Reason
Workflow error: Job execution failed: Required job 'download_repo' failed: Some("Job execution failed: Failed to checkout commit b4a2c9849791761c00c9b2a7fa2eb141d25b7af2: error: pathspec 'b4a2c9849791761c00c9b2a7fa2eb141d25b7af2' did not match any file(s) known to git\n")
It seems that Temps generates wrong git command here: https://github.com/gotempsh/temps/blame/cfe43f7660f01e1f84872cdb991f9b160be8f159/crates/temps-deployments/src/jobs/download_repo.rs#L254
Git manual states that there should be only pathspecs after -- argument, commit_sha argument should be located before it.
I've reproduced the problem manually by running git checkout -- b4a2c9849791761c00c9b2a7fa2eb141d25b7af2 in temporal local checkout created by Temps.
Operating System
Linux
Temps version
0.0.6
Docker version
28.2.2
Relevant logs
Additional context
I can make a fix
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working