Skip to content

Commit 4204c80

Browse files
committed
cleanup tests
1 parent cceadbf commit 4204c80

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

examples/panel-basic/tests/translations/spanish.spec.ts

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,14 @@ test.use({
99
},
1010
});
1111

12-
test('should display Spanish plugin translations', async ({ gotoPanelEditPage, readProvisionedDashboard, page }) => {
12+
test('should display Spanish plugin translations for all supported versions (>=11.0.0)', async ({
13+
gotoPanelEditPage,
14+
readProvisionedDashboard,
15+
page,
16+
}) => {
1317
const dashboard = await readProvisionedDashboard({ fileName: 'dashboard.json' });
1418
const panelEditPage = await gotoPanelEditPage({ dashboard, id: '1' });
15-
await page.evaluate(() => {
16-
console.log('lang', (window as any).grafanaBootData?.user?.language);
17-
console.log('toggles', (window as any).grafanaBootData?.settings.featureToggles);
18-
});
1919

20-
// For Grafana v11+, expect Spanish translations
2120
await expect(panelEditPage.panel.locator.getByText('Valor de la opción de texto:')).toBeVisible();
2221
const options = panelEditPage.getCustomOptions('Basic');
2322
const showSeriesCounter = options.getSwitch('Mostrar contador de series');

examples/panel-basic/tests/translations/swedish.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ test.use({
1111
},
1212
});
1313

14-
test('should display correct translation based on Grafana version (Swedish for v12+, English fallback for v11)', async ({
14+
test('should display correct translation based on Grafana version (Swedish for v12.1+, English fallback for v11-12.0)', async ({
1515
gotoPanelEditPage,
1616
readProvisionedDashboard,
1717
grafanaVersion,
@@ -20,9 +20,9 @@ test('should display correct translation based on Grafana version (Swedish for v
2020
const dashboard = await readProvisionedDashboard({ fileName: 'dashboard.json' });
2121
const panelEditPage = await gotoPanelEditPage({ dashboard, id: '1' });
2222

23-
const isVersion12OrHigher = semver.gte(grafanaVersion, '12.0.0');
23+
const isVersion12Point1OrHigher = semver.gte(grafanaVersion, '12.1.0');
2424

25-
if (isVersion12OrHigher) {
25+
if (isVersion12Point1OrHigher) {
2626
await expect(panelEditPage.panel.locator.getByText('Textalternativ värde:')).toBeVisible();
2727
const options = panelEditPage.getCustomOptions('Basic');
2828
const showSeriesCounter = options.getSwitch('Visa serieräknare');

0 commit comments

Comments
 (0)