Skip to content

Commit d81d440

Browse files
committed
Misc feedback
1 parent 24076fc commit d81d440

File tree

12 files changed

+140
-40
lines changed

12 files changed

+140
-40
lines changed

src/components/BlogEntry.astro

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ const { entry } = Astro.props;
6161
<Image
6262
src={entry.data.cover}
6363
alt={entry.data.coverAttribution ?? ""}
64-
class="max-h-[26rem] w-full object-cover"
64+
class="rounded max-h-[26rem] w-full object-cover"
6565
/>
6666
<figcaption class="pt-2 text-sm text-gray-50">Photo: {entry.data.coverAttribution}</figcaption>
6767
</figure>

src/components/BlogHero.astro

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ const { entry } = Astro.props;
3535
</a>
3636
</div>
3737
<div class="hidden md:block text-color-accent">
38-
Find us also on
38+
Also find us on
3939
<a href="https://twitter.com/grain_lang" class="underline">Twitter</a>
4040
and
4141
<a href="https://discord.com/invite/grain-lang" class="underline">Discord</a>
@@ -53,11 +53,13 @@ const { entry } = Astro.props;
5353
</a>
5454
</div>
5555
<div class="w-0 lg:w-7/12 pl-6">
56-
<Image
57-
src={entry.data.cover}
58-
alt={entry.data.coverAttribution ?? `${entry.data.title} cover image`}
59-
class="w-full h-full object-cover rounded"
60-
/>
56+
<a href={`/blog/${entry.id}`}>
57+
<Image
58+
src={entry.data.cover}
59+
alt={entry.data.coverAttribution ?? `${entry.data.title} cover image`}
60+
class="w-full h-full object-cover rounded"
61+
/>
62+
</a>
6163
</div>
6264
</div>
6365
</div>

src/components/BlogThumbnail.astro

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ interface Props {
1010
const { entry } = Astro.props;
1111
---
1212

13-
<div class="flex flex-col drop-shadow-sm border rounded-lg border-gray-10 dark:border-color-background-bright dark:bg-color-dim-3 overflow-hidden">
13+
<div class="flex flex-col drop-shadow-sm border rounded-lg border-gray-10 dark:border-color-background-bright dark:bg-color-dim-3 overflow-hidden hover:shadow-lg transition duration-150">
1414
<a href={`/blog/${entry.id}`} class="grow flex flex-col">
1515
<Image
1616
src={entry.data.cover}

src/components/Contributors.astro

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,15 @@ const special = [
2727
.map(contributor => (
2828
<div class="inline-block relative">
2929
<a href={contributor.html_url} class="p-0.5 inline-block">
30-
<img class="w-14 h-14 rounded-full p-0.5 shadow-md border border-color-dim-2 dark:shadow-purple-80" src={contributor.avatar_url} alt={`Image of ${contributor.login}`} />
30+
<img class={`w-14 h-14 rounded-full p-0.5 border ${special.includes(contributor.login) ? "shadow-[0_0px_8px_1px_rgb(0_0_0/0.1)] border-amber-600 shadow-amber-500" : "shadow-md border-color-dim-2"} dark:shadow-purple-80`} src={contributor.avatar_url} alt={`Image of ${contributor.login}`} />
3131
</a>
3232
{special.includes(contributor.login) && (
33-
<a href={contributor.html_url} class="absolute text-3xl bottom-0 right-0 text-yellow-500 [text-shadow:0_0_2px_#000]"></a>
33+
<a href={contributor.html_url} class="absolute text-2xl bottom-0 right-0 text-yellow-500 [text-shadow:0_0_2px_#000]">🌾</a>
3434
)}
3535
</div>
3636
))}
3737

3838
<p class="mt-6">
39-
<span class="text-2xl text-yellow-500">★</span> = Noteworthy contributors who have made signifant contributions to the project.
39+
<span class="text-2xl text-yellow-500 align-middle">🌾</span><span class="align-middle"> = Noteworthy contributors to the project.</span>
4040
</p>
4141
</div>

src/components/OpenSourceBlurb.astro

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import Card from "./Card.astro";
2020
<div class="mx-auto">
2121
<div class="grid grid-cols-1 lg:grid-cols-2 gap-5 lg:gap-14">
2222
<Card title="We continuously strive to" class="bg-color-background-bright">
23-
<ul class="pl-6 [&>li]:my-1 [&>li]:pl-1 text-color-accent list-outside list-image-[url(/src/images/check-icon.svg)]">
23+
<ul class="pl-6 [&>li]:my-1 [&>li]:pl-1 text-color-accent dark:text-[rgb(255,132,92)] list-outside list-image-[url(/src/images/check-icon.svg)]">
2424
<li>Improve the language</li>
2525
<li>Address more use cases and provide exceptional documentation</li>
2626
<li>Prioritize developer experience</li>
@@ -34,9 +34,10 @@ import Card from "./Card.astro";
3434
</p>
3535
</Card>
3636
<Card title="Sponsors and Contributors" class="bg-color-background-bright relative">
37-
<div class="z-10 absolute -top-10 right-[10rem] bg-color-blurb-4 w-36 h-[32rem] rounded-full rotate-[10deg] blur-3xl" data-desc="color-ellipsis" />
37+
<div class="z-10 absolute -top-10 right-[10rem] bg-color-blurb-4 w-36 h-[32rem] rounded-full rotate-[10deg] blur-3xl" />
3838
<div class="z-10 absolute -top-10 right-[3rem] bg-color-blurb-2 w-36 h-[32rem] rounded-full rotate-[10deg] blur-3xl" />
39-
<div class="z-10 absolute top-0 -right-[3rem] bg-color-blurb-3 w-36 h-[32rem] rounded-full rotate-[10deg] blur-3xl" data-desc="color-ellipsis" />
39+
<div class="z-10 absolute top-0 -right-[3rem] bg-color-blurb-3 w-36 h-[32rem] rounded-full rotate-[10deg] blur-3xl" />
40+
<div class="z-10 absolute w-full h-full bg-[rgb(255,255,255,0.4)] dark:bg-[rgb(29,24,46,0.4)] blur-3xl"></div>
4041
<p class="z-20">
4142
We rely on volunteer contributors and sponsors to sustain the project.
4243
Development of the Grain programming language is financially

src/components/TableOfContentsHeading.astro

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ const { heading } = Astro.props;
99
---
1010

1111
<li class="my-1.5">
12-
<a href={"#" + heading.id}>
12+
<a href={"#" + heading.slug}>
1313
{heading.text}
1414
</a>
1515
{heading.subheadings.length > 0 && (

src/content/docs/guide/05-mutation.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ It is also possible to create a binding with the same name as an existing bindin
7272
module Main
7373
7474
let val = 1
75-
let val = 2 // `val` now refers a new value
75+
let val = 2 // `val` now refers to a new value
7676
```
7777

7878
It is important to note that shadowing does not modify what the shadowed binding refers to, but rather makes a new association for a binding name within the scope:

src/content/docs/guide/06-loops.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ while (true) {
5454
```grain
5555
module Main
5656
57-
import Array from "array"
57+
from "array" include Array
5858
5959
let strings = [> "foo", "bar", "baz"]
6060

src/content/docs/guide/07-collections_and_libraries.md renamed to src/content/docs/guide/07-lists_and_arrays.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
2-
title: Collections and Libraries
3-
slug: guide/collections_and_libraries
2+
title: Lists and arrays
3+
slug: guide/lists_and_arrays
44
---
55

66
## Lists
@@ -116,7 +116,9 @@ In some cases, this could allow us to write programs that are more efficient tha
116116
However, the size of an array is fixed. To add additonal items to an array, we must append them together, which would create a brand new, third array:
117117

118118
```grain
119-
import Array from "array"
119+
module Main
120+
121+
from "array" include Array
120122
121123
let one = [> 1]
122124
let twoThree = [> 2, 3]

src/content/docs/intro/02-getting_grain.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ We have a couple different ways to get Grain. Most developers will prefer the Pa
99

1010
The Grain toolchain (including our CLI, compiler, runtime, and standard library) is shipped as a single binary. Binaries are available for [MacOS x64](#MacOS-x64---Homebrew), [Linux x64](#Linux-x64---Download), and [Windows x64](#Windows-x64---Download).
1111

12-
**Note:** These binaries are a bit slow when first building a project (around 70 seconds). The packaged compiler is running in JavaScript, _and_ it builds and writes the runtime & standard library into your project. If you need raw speed, you can build the native compiler from source! See [Building Grain from Source](#Building-Grain-from-Source) below.
12+
**Note:** These binaries are a bit slow when first building a project (around 10 seconds). The packaged compiler is running in JavaScript, _and_ it builds and writes the runtime & standard library into your project. If you need raw speed, you can build the native compiler from source! See [Building Grain from Source](#Building-Grain-from-Source) below.
1313

1414
### MacOS x64 - Homebrew
1515

@@ -23,30 +23,30 @@ _The `--no-quarantine` flag will avoid having to approve the binary in the Secur
2323

2424
### MacOS x64 - Download
2525

26-
If you'd prefer not to use homebrew, you can [download it](https://github.com/grain-lang/grain/releases/download/grain-v0.5.13/grain-mac-x64) directly from GitHub or using `curl`.
26+
If you'd prefer not to use homebrew, you can [download it](https://github.com/grain-lang/grain/releases/download/grain-v0.6.6/grain-mac-x64) directly from GitHub or using `curl`.
2727

2828
```sh
2929
sudo curl -L --output /usr/local/bin/grain \
30-
https://github.com/grain-lang/grain/releases/download/grain-v0.5.13/grain-mac-x64 \
30+
https://github.com/grain-lang/grain/releases/download/grain-v0.6.6/grain-mac-x64 \
3131
&& sudo chmod +x /usr/local/bin/grain
3232
```
3333

3434
### Linux x64 - Download
3535

36-
You can [download it](https://github.com/grain-lang/grain/releases/download/grain-v0.5.13/grain-linux-x64) directly from GitHub or using `curl`.
36+
You can [download it](https://github.com/grain-lang/grain/releases/download/grain-v0.6.6/grain-linux-x64) directly from GitHub or using `curl`.
3737

3838
```sh
3939
sudo curl -L --output /usr/local/bin/grain \
40-
https://github.com/grain-lang/grain/releases/download/grain-v0.5.13/grain-linux-x64 \
40+
https://github.com/grain-lang/grain/releases/download/grain-v0.6.6/grain-linux-x64 \
4141
&& sudo chmod +x /usr/local/bin/grain
4242
```
4343

4444
### Windows x64 - Download
4545

46-
You can [download it](https://github.com/grain-lang/grain/releases/download/grain-v0.5.13/grain-win-x64.exe) directly from GitHub or using `curl`.
46+
You can [download it](https://github.com/grain-lang/grain/releases/download/grain-v0.6.6/grain-win-x64.exe) directly from GitHub or using `curl`.
4747

4848
```batch
49-
curl -LO https://github.com/grain-lang/grain/releases/download/grain-v0.5.13/grain-win-x64.exe
49+
curl -LO https://github.com/grain-lang/grain/releases/download/grain-v0.6.6/grain-win-x64.exe
5050
```
5151

5252
You'll either want to put it into your path or keep it inside your project and invoke with `.\grain-win-x64.exe`.

0 commit comments

Comments
 (0)