Remove todos

Author: Josh Price

lib/graphql.ex

@@ -98,7 +98,6 @@ defmodule GraphQL do
   end
 
   defp execute_with_optional_validation(schema, query, opts) do
-    # TODO: use the `with` statement to compose write this in a nicer way
     case GraphQL.Lang.Parser.parse(query) do
       {:ok, document} ->
         case optionally_validate(Keyword.get(opts, :validate, true), schema, document) do

lib/graphql/execution/execution_context.ex

@@ -18,7 +18,7 @@ defmodule GraphQL.Execution.ExecutionContext do
       fragments: %{},
       root_value: root_value,
       operation: nil,
-      variable_values: variable_values || %{}, # TODO: We need to deeply set keys as strings or atoms. not allow both.
+      variable_values: variable_values || %{},
       errors: []
     }, fn(definition, context) ->
 
@@ -43,4 +43,3 @@ defmodule GraphQL.Execution.ExecutionContext do
     put_in(context.errors, [%{"message" => msg} | context.errors])
   end
 end
-

lib/graphql/execution/executor.ex

@@ -172,7 +172,6 @@ defmodule GraphQL.Execution.Executor do
 
   @spec complete_value(%NonNull{}, ExecutionContext.t, GraphQL.Document.t, any, any) :: {ExecutionContext.t, map}
   defp complete_value(%NonNull{ofType: inner_type}, context, field_asts, info, result) do
-    # TODO: Null Checking
     complete_value(unwrap_type(inner_type), context, field_asts, info, result)
   end
 

lib/graphql/execution/variables.ex

@@ -19,7 +19,6 @@ defmodule GraphQL.Execution.Variables do
 
   defp get_variable_value(schema, ast, input_value) do
     type = GraphQL.Schema.type_from_ast(ast.type, schema)
-    # todo soooooo much error handling. so much.
     value_for(ast, type, input_value)
   end
 

test/graphql/execution/variables_test.exs

@@ -13,8 +13,6 @@ defmodule GraphQL.Execution.Executor.VariableTest do
   defmodule GraphQL.Type.TestComplexScalar do
     defstruct name: "ComplexScalar", description: ""
   end
-  # TODO: Why can't I have a defimpl in here?
-  # Should I put this in a support file?
 
   alias GraphQL.Type.TestComplexScalar