Comment

Author: ardatan

lib/query-plan-executor/src/lib.rs

@@ -518,6 +518,9 @@ impl ExecutablePlanNode for ParallelNode {
                                 number_of_indexes += 1;
                             }
                         }
+                        // We collect indexes in paths (replacing "@") to mutate the final result later
+                        // This is not a case for SequenceNode only for ParallelNode
+                        // Because in ParallelNode, we can't hold the mutable references
                         let mut indexes_in_paths: Vec<VecDeque<usize>> = vec![];
                         traverse_and_callback(
                             data,
@@ -551,7 +554,10 @@ impl ExecutablePlanNode for ParallelNode {
                                             None,
                                         )
                                     }
-                                    .unwrap_or(false);
+                                    .unwrap_or_else(|e| {
+                                        warn!("Error while projecting representations for FetchNode: {:?} {}", fetch_node, e);
+                                        false
+                                    });
                                 if is_projected {
                                     indexes_in_paths.push(indexes_in_path);
                                 }
@@ -593,6 +599,10 @@ impl ExecutablePlanNode for ParallelNode {
                         }
                     }
                     ParallelJob::Flatten(mut result, path) => {
+                        /*
+                         * We iterate over the returned entities,
+                         * and merge them into the final response based on the path segments collected
+                         **/
                         if let Some(entities) = result.entities {
                             'entity_loop: for (entity, indexes_in_path) in
                                 entities.into_iter().zip(result.indexes_in_paths.iter_mut())