feat(core): backport 4 improvements to serializer from prosemirror-markdown upstream#1046
Draft
feat(core): backport 4 improvements to serializer from prosemirror-markdown upstream#1046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports 4 improvements from the
prosemirror-markdownupstream into the fork'sMarkdownSerializerState:serialize()withstrict: falseno longer throws on unknown node types; instead, block nodes render their content and leaf nodes are silently skippedgetMark()with strict fallback — unknown mark types throw in strict mode (default) and are silently ignored in non-strict mode, instead of causing a runtime errorexpelEnclosingWhitespace— trailing whitespace is no longer expelled from a mark when that mark continues on the next sibling node (fixes spurious spaces between adjacent same-mark nodes)atBlockStarttracking — start-of-line escape logic now uses a dedicatedatBlockStartflag instead of theatBlank() || closedheuristic, making#,-,>etc. escape only at actual block start, not after inline line breaksTests:
prosemirror-markdown/test1.tstoMarkdown.test.tsexpelEnclosingWhitespacewith mark continuation, andatBlockStartprecision for start-of-line escaping