-
Notifications
You must be signed in to change notification settings - Fork 39
Open
Description
Reading through the code, the approval list has several issues:
r=meon a commit will put both the posting user and a username "me" on the approval listEdit: This isn't true,r=usernameon a commit is accepted even if neither the poster nor the referenced username are reviewers. This seems like a reasonably major issue.head_commentsis actually filtered to only comments made by reviewers.r=metajackon a commit will put both the posting user and "metajack" on the approval list; in this instance, it's seeing ther=meprefix and not realizing that the "me" was part of a larger usernamer+ $SHAandr=username $SHAon PR comments requires$SHAto be all lowercase. Minor issue, but it really should accept uppercase as well (and the regex should require hex characters, rather than any letter, although that's moot since a non-hex char won't match the current sha anyway).
A couple of priority issues as well:
Edit: This isn't true, as above,p=100on a commit is accepted by anyone, even a non-reviewer, even if it's on a different comment than the comment that establishes approval.head_commentsis filtered to only reviewer comments. It still allows it on a different comment but that's probably fine.p=100can't be specified on a PR comment, even one that establishes approval.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels