#1 - Added more tests and test coverage

Signed-off-by: Gregor Anders <gregor.anders@gmail.com>

Author: gregoranders

.github/actions/build-info/tsconfig.json

@@ -6,6 +6,7 @@
     "esModuleInterop": true,
     "noImplicitAny": true,
     "sourceMap": true,
+    "strict": true,
     "outDir": "./",
   },
   "include": [

.github/actions/create-release/index.ts

@@ -13,6 +13,11 @@ async function run(): Promise<void> {
 
   const { owner, repo } = context.repo;
 
+  if (!process.env.GITHUB_TOKEN) {
+    core.setFailed("Missing GitHub token");
+    return;
+  }
+
   const github: GitHub = new GitHub(process.env.GITHUB_TOKEN);
 
   let releaseID: number = -1;

.github/actions/create-release/tsconfig.json

@@ -6,6 +6,7 @@
     "esModuleInterop": true,
     "noImplicitAny": true,
     "sourceMap": true,
+    "strict": true,
     "outDir": "./",
   },
   "include": [

.github/actions/gulpfile.ts

@@ -10,23 +10,16 @@ import * as ncc from "@zeit/ncc";
 
 const basePath: fs.PathLike = fs.realpathSync(path.resolve(__dirname, "../.."));
 
-interface INCCCompileOptions {
-  cache?: boolean;
-  debugLog?: boolean;
-  externals?: string[];
-  filterAssetBase?: string;
-  minify?: boolean;
-  quiet?: boolean;
-  v8cache?: boolean;
-}
-
-function nccCompile(options?: INCCCompileOptions): any {
+function nccCompile(): any {
   return through.obj((chunk: any, encoding: string, callback: through.TransformCallback): any => {
     if (chunk.isBuffer()) {
-      ncc(chunk.path, Object.assign(options, {
+      ncc(chunk.path, {
+        cache: false,
+        minify: false,
+        quiet: false,
         sourceMap: false,
         sourceMapRegister: false,
-      })).then((result: any): void => {
+      }).then((result: any): void => {
       chunk.path = chunk.path.replace(".ts", ".js");
       chunk.contents = Buffer.from(result.code);
       callback(undefined, chunk);
@@ -38,11 +31,7 @@ function nccCompile(options?: INCCCompileOptions): any {
 }
 
 gulp.task("default", (): NodeJS.ReadWriteStream => {
-  return gulp.src(path.join(basePath, ".github/actions/**/*.ts"))
-            .pipe(nccCompile({
-              cache: false,
-              minify: false,
-              quiet: false,
-            }))
+  return gulp.src(path.join(basePath, ".github/actions/**/index.ts"))
+            .pipe(nccCompile())
             .pipe(gulp.dest(path.resolve(basePath, ".github/actions/")));
 });

.github/actions/prepare-release/tsconfig.json

@@ -6,6 +6,7 @@
     "esModuleInterop": true,
     "noImplicitAny": true,
     "sourceMap": true,
+    "strict": true,
     "outDir": "./",
   },
   "include": [

.github/actions/upload-asset/index.ts

@@ -12,6 +12,11 @@ async function run(): Promise<void> {
   const assetName: string = core.getInput("name", {required: true});
   const assetPath: string = core.getInput("path", {required: true});
 
+  if (!process.env.GITHUB_TOKEN) {
+    core.setFailed("Missing GitHub token");
+    return;
+  }
+
   const github: GitHub = new GitHub(process.env.GITHUB_TOKEN);
 
   const fullPathChecked: fs.PathLike = path.resolve(fs.realpathSync(assetPath));
@@ -23,7 +28,7 @@ async function run(): Promise<void> {
   try {
     const headers: Octokit.ReposUploadReleaseAssetParamsHeaders = {
       "content-length": fs.statSync(fullPathChecked).size,
-      "content-type": getType(fullPathChecked),
+      "content-type": getType(fullPathChecked) || "application/zip",
     };
 
     const response: Octokit.Response<Octokit.ReposUploadReleaseAssetResponse> = await github.repos.uploadReleaseAsset({
@@ -33,9 +38,9 @@ async function run(): Promise<void> {
       url: assetUploadURL,
     });
 
-    console.log(response.data);
+    const data: Octokit.ReposUploadReleaseAssetResponseValue = response.data as any;
 
-    core.setOutput("url", "abc");
+    core.setOutput("url", data.browser_download_url);
   } catch (error) {
     core.setFailed("Error");
     return;

.github/actions/upload-asset/tsconfig.json

@@ -6,6 +6,7 @@
     "esModuleInterop": true,
     "noImplicitAny": true,
     "sourceMap": true,
+    "strict": true,
     "outDir": "./",
   },
   "include": [

.github/workflows/development.yml

@@ -39,6 +39,11 @@ jobs:
         npm run build
         npm test
         npm run dist
+    - name: test coverage
+      uses: coverallsapp/github-action@master
+      with:
+        github-token: ${{ secrets.GITHUB_TOKEN }}
+        path-to-lcov: ./coverage/lcov.info
       env:
         CI: true
         GITHUB_CONTEXT: ${{ toJson(github) }}

.github/workflows/master.yml

@@ -46,6 +46,11 @@ jobs:
         GITHUB_HEAD_REF: ${{ github.head_ref }}
         GITHUB_BASE_REF: ${{ github.base_ref }}
         GITHUB_COMMIT: ${{ github.sha }}
+    - name: test coverage
+      uses: coverallsapp/github-action@master
+      with:
+        github-token: ${{ secrets.GITHUB_TOKEN }}
+        path-to-lcov: ./coverage/lcov.info
     - name: release
       id: release
       uses: ./.github/actions/create-release

.github/workflows/release.yml

@@ -46,6 +46,11 @@ jobs:
         GITHUB_HEAD_REF: ${{ github.head_ref }}
         GITHUB_BASE_REF: ${{ github.base_ref }}
         GITHUB_COMMIT: ${{ github.sha }}
+    - name: test coverage
+      uses: coverallsapp/github-action@master
+      with:
+        github-token: ${{ secrets.GITHUB_TOKEN }}
+        path-to-lcov: ./coverage/lcov.info
     - name: prepare release
       id: prepare
       uses: ./.github/actions/prepare-release