Hyphenation before bars is inconsistent

[davidweichiang]

When a word is broken across a bar, whether there is a hyphen is not consistent. I am not sure what the right behavior should be, though.

\gresetinitiallines{0}
\gabcsnippet{a(gg)(:)a(g) (::) a(g)(:)a(g) (::) abc(g)(:)a(g) (::) abcd(g)(:)a(g)}
\gabcsnippet{a(gg)(`)a(g) (::) a(g)(`)a(g) (::) abc(g)(`)a(g) (::) abcd(g)(`)a(g)}
\gabcsnippet{a(gg)*(:)a(g) (::) a(g)*(:)a(g) (::) abc(g)*(:)a(g) (::) abcd(g)*(:)a(g)}

Under the old bar spacing algorithm, it's slightly different:

\gresetinitiallines{0}
\gresetbarspacing{old}
\gabcsnippet{a(gg)(:)a(g) (::) a(g)(:)a(g) (::) abc(g)(:)a(g) (::) abcd(g)(:)a(g)}
\gabcsnippet{a(gg)(`)a(g) (::) a(g)(`)a(g) (::) abc(g)(`)a(g) (::) abcd(g)(`)a(g)}
\gabcsnippet{a(gg)*(:)a(g) (::) a(g)*(:)a(g) (::) abc(g)*(:)a(g) (::) abcd(g)*(:)a(g)}

[rpspringuel]

The last line in the examples I would consider unrealistic. We don't usually put text markers like * into the middle of a word.

For the first two lines, I would say that a hyphen should be inserted whenever the space between the text exceeds maximumspacewithoutdash (which, of note, points out an inconsistency in our code base as we use both "dash" and "hyphen" at different points). The problem is probably due to the intervening bar syllable. I'd be willing to bet that when calculating the distance between the text, the code only looks forward (or back) one syllable. The bar syllable thus effectively hides the next syllable because said text is now not in the adjacent syllable, but rather the next one.

[davidweichiang]

OK, I won't worry about the third line (though maybe a warning could be issued if it happens).

It makes sense for the hyphenation code to skip over any syllables (whether bar syllables or normal syllables) that have no text in order to find the next piece of text. The current code certainly isn't doing that.

I think that clears up what the hyphenation should be doing.

[davidweichiang]

Something similar happens with syllables that have notes but no text.

\gabcsnippet{a(gg)(g)a(g) (::) a(g)(g)a(g) (::) abc(g)(g)a(g) (::) abcd(g)(g)a(g)}

[rpspringuel]

That last one makes even less sense to me than having a bar syllable with text-markers in the middle of a word.

Thinking further about it, I would consider most of this non-standard gabc. What I would expect is something more like:

\gabcsnippet{a(gg:)a(g) (::) a(g:)a(g) (::) abc(g:)a(g) (::) abcd(g:)a(g)}
\gabcsnippet{a(gg`)a(g) (::) a(g`)a(g) (::) abc(g`)a(g) (::) abcd(g`)a(g)}

Having both notes and bars in the same syllable is allowed, and give results which I think are more as expected: