Document viewer: revisit Previous and Next buttons ❤️❤️❤️ #470
Description
Weirdly lots of people have suddenly been asking about this: they'd like a way to cycle through documents within a folder of a workspace without going back to the workspace, i.e. "previous and next file in the same location".
Relatedly, when we perform a search in Giant, if a user double clicks on a search result AND that search result is for a file type (e.g. jpeg, wordfile, video, audio, email) that isn't rendered in our combined document viewer, then the view has a bar at the bottom showing very little arrows to go to the previous or next search result from the list in the earlier search.
In the combined document viewer no such feature exists; however there are up and down arrows to cycle through search hits within the current document (the top layer being for hits of the original search time and the bottom layer being for an additional "find x in document" unrelated to the original search).
So there are three contexts for previous and next. Ideally we'd amalgamate all these features into something a bit more coherent ...
- PREVIOUS/NEXT DOCUMENT
Take account of the context from which a document is opened, and once opened, in every single way we render documents,
- If a user opens the document from a search, previous and next buttons should cycle through the documents that matches that search.
- If a user opens the document from a dataset or workspace, previous and next buttons should cycle through the documents at the same file hierarchy level.
- If a user opens a document directly from a URL, disable the previous and next buttons. (but c.f. Show workspace path(s) in document info sidebar ❤️❤️❤️❤️❤️ #393)
Plus more granular search-related navigation:
- SIMPLE FIND WITHIN DOCUMENT
In the combined document viewer, and in the text, timecodes, OCR, translated views of other document viewers:
- An initially empty text entry field with previous and next buttons to "find in file". (This feature is already present in the combined document viewer and is also provided by our older PDF viewer)
- PREVIOUS/NEXT HIT WITHIN DOCUMENT
This feature (already present) only displays when people come to a combined document view from a search. So we already have some sort of mechanism to distinguish the context from which a document is opened.
In the combined document viewer, if it was arrived at from a search there is an additional search/prev/next UI allowing the user to move through the document finding matches for the original search performed to get to this document. This came as a user request and has proved useful, but there is some confusion with the above feature. They're stacked when the scneario occurs:
My suggestion would be:
- Move all "within document" search features (2 and 3 above) into a pane at the top of the sidebar above the metadata, and that does not scroll away when people scroll through the locaions and metadata. The document actions should also live in this pane - but not "view as text".... (edit: consolidate yes, into the sidebar ... maybe not)
- Aways show a strip below the document view, even in the combined document viewer. Show buttons for all views (i.e. in the combined document viewer allow people to switch to text and preview modes, and back to "combined". (edit: see Document view: consistent view mode switch UX, better wrapping sidebar #607 )
- In this strip, show the previous and next document buttons (1) - again, even in the combined document viewer. It's much easier to copy and paste text from the old fashioned viewers than it is from the combined document viewer, so those views still have their uses. (edit: see Karpow that workspace folder! #614 )