네이밍 수정

Author: gunkim

rate-limiter/src/main/java/io/github/gunkim/ratelimiter/Application.java

@@ -1,22 +1,22 @@
 package io.github.gunkim.ratelimiter;
 
 
-import io.github.gunkim.ratelimiter.bucket.TokenBucketRateLimiter;
+import io.github.gunkim.ratelimiter.bucket.TokenRateLimiterRateLimiter;
 
 public class Application {
     public static void main(String[] args) {
         //4초에 2개 요청에 대한 처리율 제한 설정
         final int bucketSize = 20;
         final long refillRate = 60_000L;
-        var bucket = new TokenBucketRateLimiter(bucketSize, refillRate);
+        var bucket = new TokenRateLimiterRateLimiter(bucketSize, refillRate);
 
         while (true) {
             processRequest(bucket);
             sleep(1_000);
         }
     }
 
-    private static void processRequest(TokenBucketRateLimiter bucket) {
+    private static void processRequest(TokenRateLimiterRateLimiter bucket) {
         bucket.request(() -> System.out.println("Request"));
     }
 

rate-limiter/src/main/java/io/github/gunkim/ratelimiter/RateLimiter.java

@@ -0,0 +1,5 @@
+package io.github.gunkim.ratelimiter;
+
+public interface RateLimiter {
+    void request(Runnable request);
+}

rate-limiter/src/main/java/io/github/gunkim/ratelimiter/bucket/Bucket.java

@@ -1,5 +1,6 @@
 package io.github.gunkim.ratelimiter.bucket;
 
+import io.github.gunkim.ratelimiter.RateLimiter;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -17,16 +18,16 @@
  * <p>
  * 고정된 처리율로 안정적인 트래픽 처리엔 좋지만, 트래픽이 몰리게 되면 요청이 버려질 수 있음.
  */
-public class LeakyBucketRateLimiter implements AutoCloseable, Bucket {
-    private static final Logger logger = LoggerFactory.getLogger(LeakyBucketRateLimiter.class);
+public class LeakyRateLimiterRateLimiter implements AutoCloseable, RateLimiter {
+    private static final Logger logger = LoggerFactory.getLogger(LeakyRateLimiterRateLimiter.class);
 
     private final Queue<Runnable> queue;
     private final int bucketSize;
     private final int batchSize;
 
     private final ScheduledExecutorService executorService;
 
-    public LeakyBucketRateLimiter(int bucketSize, long scheduleInterval, int batchSize) {
+    public LeakyRateLimiterRateLimiter(int bucketSize, long scheduleInterval, int batchSize) {
         this.bucketSize = bucketSize;
         this.batchSize = batchSize;
 

rate-limiter/src/main/java/io/github/gunkim/ratelimiter/bucket/LeakyBucketRateLimiter.java renamed to rate-limiter/src/main/java/io/github/gunkim/ratelimiter/bucket/LeakyRateLimiterRateLimiter.java

@@ -1,5 +1,6 @@
 package io.github.gunkim.ratelimiter.bucket;
 
+import io.github.gunkim.ratelimiter.RateLimiter;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -17,13 +18,13 @@
  * 구현이 쉬우며 많은 기업이 이용하고 있다. 하지만 안정적인 처리를 보장하진 못한다.
  * 예를 들어, 초반에 트래픽이 몰려 모든 토큰이 소비된다면 이후 요청은 토큰이 리필될 때까지 처리되지 못한다.
  */
-public class TokenBucketRateLimiter implements AutoCloseable, Bucket {
-    private static final Logger logger = LoggerFactory.getLogger(TokenBucketRateLimiter.class);
+public class TokenRateLimiterRateLimiter implements AutoCloseable, RateLimiter {
+    private static final Logger logger = LoggerFactory.getLogger(TokenRateLimiterRateLimiter.class);
 
     private final ScheduledExecutorService executorService;
     private final AtomicInteger tokens;
 
-    public TokenBucketRateLimiter(int bucketSize, long refillRate) {
+    public TokenRateLimiterRateLimiter(int bucketSize, long refillRate) {
         this.executorService = Executors.newSingleThreadScheduledExecutor();
         this.tokens = new AtomicInteger(bucketSize);
 

rate-limiter/src/main/java/io/github/gunkim/ratelimiter/bucket/TokenBucketRateLimiter.java renamed to rate-limiter/src/main/java/io/github/gunkim/ratelimiter/bucket/TokenRateLimiterRateLimiter.java

@@ -13,7 +13,7 @@
 import static org.mockito.Mockito.times;
 
 @DisplayName("TokenBucket은")
-class TokenBucketRateLimiterTest {
+class TokenRateLimiterRateLimiterTest {
     private Runnable request;
 
     @BeforeEach
@@ -23,15 +23,15 @@ void setUp() {
 
     @Test
     void 토큰이_없는_경우_요청이_무시된다() {
-        try (var tokenBucket = new TokenBucketRateLimiter(0, 20_000)) {
+        try (var tokenBucket = new TokenRateLimiterRateLimiter(0, 20_000)) {
             tokenBucket.request(request);
             Mockito.verify(request, never()).run();
         }
     }
 
     @Test
     void 토큰이_최대치일_때_모든_요청이_처리된다() {
-        try (var tokenBucket = new TokenBucketRateLimiter(10, 20_000)) {
+        try (var tokenBucket = new TokenRateLimiterRateLimiter(10, 20_000)) {
             for (int i = 0; i < 10; i++) {
                 tokenBucket.request(request);
             }
@@ -41,7 +41,7 @@ void setUp() {
 
     @Test
     void 토큰이_모두_사용된_후_나머지_요청이_무시된다() {
-        try (var tokenBucket = new TokenBucketRateLimiter(3, 20_000)) {
+        try (var tokenBucket = new TokenRateLimiterRateLimiter(3, 20_000)) {
             for (int i = 0; i < 6; i++) {
                 tokenBucket.request(request);
             }
@@ -51,7 +51,7 @@ void setUp() {
 
     @Test
     void 다중_스레드_환경에서_정상_작동한다() {
-        try (var tokenBucket = new TokenBucketRateLimiter(100, 5_000)) {
+        try (var tokenBucket = new TokenRateLimiterRateLimiter(100, 5_000)) {
             ExecutorService taskExecutor = Executors.newFixedThreadPool(10);
             for (int i = 0; i < 150; i++) {
                 taskExecutor.execute(() -> tokenBucket.request(request));