숫자야구 테스트 코드 작성

Author: gunkim

number-baseball/build.gradle.kts

@@ -0,0 +1,6 @@
+dependencies {
+    testImplementation(platform("org.junit:junit-bom:5.11.3"))
+    testImplementation("org.junit.jupiter:junit-jupiter")
+    testImplementation("org.mockito:mockito-core:5.14.2")
+    testImplementation("org.assertj:assertj-core:3.26.3")
+}

number-baseball/src/main/java/io/github/gunkim/baseball/Application.java

@@ -2,6 +2,7 @@
 
 import io.github.gunkim.baseball.application.ConsoleInput;
 import io.github.gunkim.baseball.application.ConsoleOutput;
+import io.github.gunkim.baseball.application.DefaultInputScanner;
 import io.github.gunkim.baseball.application.RandomNumberInput;
 import io.github.gunkim.baseball.domain.BaseBallGame;
 
@@ -11,7 +12,7 @@ public class Application {
 
     public static void main(final String[] args) {
         new BaseBallGame(
-                new ConsoleInput(TOTAL_BALL_COUNT),
+                new ConsoleInput(new DefaultInputScanner(), TOTAL_BALL_COUNT),
                 new RandomNumberInput(TOTAL_BALL_COUNT),
                 new ConsoleOutput(),
                 TOTAL_BALL_COUNT,

number-baseball/src/main/java/io/github/gunkim/baseball/application/ConsoleInput.java

@@ -4,28 +4,28 @@
 import io.github.gunkim.baseball.domain.BallNumbers;
 import io.github.gunkim.baseball.domain.Input;
 
-import java.util.Scanner;
-
 public class ConsoleInput implements Input {
-    private static final Scanner SCANNER = new Scanner(System.in);
-
+    private final InputScanner inputScanner;
     private final int ballCount;
 
-    public ConsoleInput(final int ballCount) {
+    public ConsoleInput(InputScanner inputScanner, int ballCount) {
+        this.inputScanner = inputScanner;
         this.ballCount = ballCount;
     }
 
     @Override
     public BallNumbers ballNumbers() {
-        final String input = SCANNER.nextLine();
+        final String input = inputScanner.input();
+
+        //TODO: 입력한 값에 대한 유효성 검증은 여기서 처리하는게 맞을까? 혹은 도메인 로직일까?
         if (input.length() != ballCount) {
-            throw new IllegalArgumentException("3자리 숫자를 입력해주세요.");
+            throw new IllegalArgumentException("%d자리 숫자를 입력해주세요. 현재: %s".formatted(ballCount, input));
         }
         if (input.chars().distinct().count() != ballCount) {
-            throw new IllegalArgumentException("중복되지 않는 숫자를 입력해주세요.");
+            throw new IllegalArgumentException("중복되지 않는 숫자를 입력해주세요. 현재: %s".formatted(input));
         }
         if (input.chars().anyMatch(c -> c < '1' || c > '9')) {
-            throw new IllegalArgumentException("1부터 9까지의 숫자를 입력해주세요.");
+            throw new IllegalArgumentException("1부터 9까지의 숫자를 입력해주세요. 현재: %s".formatted(input));
         }
         return new BallNumbers(input.chars()
                 .mapToObj(c -> (char) c)

number-baseball/src/main/java/io/github/gunkim/baseball/application/DefaultInputScanner.java

@@ -0,0 +1,12 @@
+package io.github.gunkim.baseball.application;
+
+import java.util.Scanner;
+
+public class DefaultInputScanner implements InputScanner {
+    private static final Scanner SCANNER = new Scanner(System.in);
+
+    @Override
+    public String input() {
+        return SCANNER.nextLine();
+    }
+}

number-baseball/src/main/java/io/github/gunkim/baseball/application/InputScanner.java

@@ -0,0 +1,6 @@
+package io.github.gunkim.baseball.application;
+
+@FunctionalInterface
+public interface InputScanner {
+    String input();
+}

number-baseball/src/main/java/io/github/gunkim/baseball/domain/BallNumbers.java

@@ -12,15 +12,16 @@ public BallNumbers(final List<BallNumber> ballNumbers) {
     }
 
     public Result match(final BallNumbers otherBalls) {
-        int strike = 0, ball = 0;
+        int strike = 0;
+        int ball = 0;
 
         for (int i = 0; i < this.ballNumbers.size(); i++) {
             final BallNumber myBall = this.ballNumbers.get(i);
             final BallNumber otherBall = otherBalls.ballNumbers.get(i);
 
             if (myBall.equals(otherBall)) {
                 strike++;
-            } else if (this.hasBallNumber(myBall)) {
+            } else if (hasBallNumber(myBall)) {
                 ball++;
             }
         }

number-baseball/src/test/java/io/github/gunkim/baseball/application/ConsoleInputTest.java

@@ -0,0 +1,39 @@
+package io.github.gunkim.baseball.application;
+
+import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.api.Test;
+
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+@DisplayName("ConsoleInput은")
+class ConsoleInputTest {
+    @Test
+    void 입력한_숫자가_세자리가_아닐_경우_예외가_발생한다() {
+        final InputScanner mockInputScanner = () -> "1234";
+        final ConsoleInput consoleInput = new ConsoleInput(mockInputScanner, 3);
+
+        assertThatThrownBy(consoleInput::ballNumbers)
+                .isInstanceOf(IllegalArgumentException.class)
+                .hasMessage("3자리 숫자를 입력해주세요. 현재: 1234");
+    }
+
+    @Test
+    void 중복된_숫자를_입력할_경우_예외가_발생한다() {
+        final InputScanner mockInputScanner = () -> "111";
+        final ConsoleInput consoleInput = new ConsoleInput(mockInputScanner, 3);
+
+        assertThatThrownBy(consoleInput::ballNumbers)
+                .isInstanceOf(IllegalArgumentException.class)
+                .hasMessage("중복되지 않는 숫자를 입력해주세요. 현재: 111");
+    }
+
+    @Test
+    void test() {
+        final InputScanner mockInputScanner = () -> "abc";
+        final ConsoleInput consoleInput = new ConsoleInput(mockInputScanner, 3);
+
+        assertThatThrownBy(consoleInput::ballNumbers)
+                .isInstanceOf(IllegalArgumentException.class)
+                .hasMessage("1부터 9까지의 숫자를 입력해주세요. 현재: abc");
+    }
+}

number-baseball/src/test/java/io/github/gunkim/baseball/domain/BallNumbersTest.java

@@ -0,0 +1,67 @@
+package io.github.gunkim.baseball.domain;
+
+import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.api.Test;
+
+import java.util.List;
+import java.util.stream.Stream;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+@DisplayName("BallNumbers는")
+class BallNumbersTest {
+
+    @Test
+    void 모든_숫자가_같다면_올_스트라이크_노_낫싱이다() {
+        final List<BallNumber> numbers = Stream.of(1, 2, 3)
+                .map(BallNumber::of)
+                .toList();
+
+        final var totalBallCount = 3;
+        final var ballNumbers = new BallNumbers(numbers);
+        final var otherBallNumbers = new BallNumbers(numbers);
+
+        final Result result = ballNumbers.match(otherBallNumbers);
+
+        assertAll(
+                () -> assertTrue(result.isAllStrike(totalBallCount)),
+                () -> assertFalse(result.isNothing())
+        );
+    }
+
+    @Test
+    void 모든_숫자가_다르다면_낫싱_노_스트라이크이다() {
+        final var ballNumbers = new BallNumbers(Stream.of(1, 2, 3)
+                .map(BallNumber::of)
+                .toList());
+        final var otherBallNumbers = new BallNumbers(Stream.of(4, 5, 6)
+                .map(BallNumber::of)
+                .toList());
+
+        final Result result = ballNumbers.match(otherBallNumbers);
+
+        assertAll(
+                () -> assertTrue(result.isNothing()),
+                () -> assertFalse(result.isAllStrike(3))
+        );
+    }
+
+    @Test
+    public void 숫자123과_숫자231은_1스트라이크_2볼이다() {
+        final var ballNumbers = new BallNumbers(Stream.of(1, 2, 3)
+                .map(BallNumber::of)
+                .toList());
+        final var otherBallNumbers = new BallNumbers(Stream.of(2, 3, 1)
+                .map(BallNumber::of)
+                .toList());
+
+        final Result result = ballNumbers.match(otherBallNumbers);
+
+        assertAll(
+                () -> assertEquals(1, result.strike()),
+                () -> assertEquals(2, result.ball()),
+                () -> assertFalse(result.isNothing()),
+                () -> assertFalse(result.isAllStrike(3))
+        );
+    }
+}