Drop support for Python 3.8 (#160)

Fixes #155

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: hamdanal

.github/workflows/tests.yml

@@ -20,12 +20,12 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest]
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13", "3.14"]
+        python-version: ["3.9", "3.10", "3.11", "3.12", "3.13", "3.14"]
         include:
           - os: windows-latest
-            python-version: "3.11"
+            python-version: "3.13"
           - os: macos-latest
-            python-version: "3.11"
+            python-version: "3.13"
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v4

CHANGELOG.md

@@ -2,6 +2,11 @@
 
 ## Unreleased
 
+### Features
+- [GH-155](https://github.com/hamdanal/rich-argparse/issues/155),
+  [PR-160](https://github.com/hamdanal/rich-argparse/pull/160)
+  Python 3.8 is no longer supported (EOL since 7/10/2024)
+
 ## 1.7.0 - 2025-02-08
 
 ### Features

CONTRIBUTING.md

@@ -11,7 +11,7 @@ typo fixes where an issue may not be needed).
 
 ## Getting started
 
-*python* version 3.8 or higher is required for development.
+*python* version 3.9 or higher is required for development.
 
 1. Fork the repository on GitHub.
 

pyproject.toml

@@ -17,7 +17,6 @@ classifiers = [
   "Intended Audience :: Developers",
   "License :: OSI Approved :: MIT License",
   "Operating System :: OS Independent",
-  "Programming Language :: Python :: 3.8",
   "Programming Language :: Python :: 3.9",
   "Programming Language :: Python :: 3.10",
   "Programming Language :: Python :: 3.11",
@@ -30,7 +29,7 @@ keywords = ["argparse", "rich", "help-formatter", "optparse"]
 dependencies = [
   "rich >= 11.0.0",
 ]
-requires-python = ">=3.8"
+requires-python = ">=3.9"
 
 [project.urls]
 Homepage = "https://github.com/hamdanal/rich-argparse"
@@ -65,7 +64,7 @@ isort.extra-standard-library = ["typing_extensions"]
 flake8-tidy-imports.ban-relative-imports = "all"
 
 [tool.mypy]
-python_version = "3.8"
+python_version = "3.9"
 strict = true
 local_partial_types = true
 

rich_argparse/_argparse.py

@@ -6,7 +6,6 @@
 
 import argparse
 import re
-import sys
 
 import rich_argparse._lazy_rich as r
 from rich_argparse._common import (
@@ -291,16 +290,13 @@ def find_span(_string: str) -> tuple[int, int]:
             return _start, _end
 
         for action in options:  # start with the options
-            if sys.version_info >= (3, 9):  # pragma: >=3.9 cover
-                usage = action.format_usage()
-                if isinstance(action, argparse.BooleanOptionalAction):
-                    for option_string in action.option_strings:
-                        start, end = find_span(option_string)
-                        yield r.Span(start, end, "argparse.args")
-                        pos = end + 1
-                    continue
-            else:  # pragma: <3.9 cover
-                usage = action.option_strings[0]
+            usage = action.format_usage()
+            if isinstance(action, argparse.BooleanOptionalAction):
+                for option_string in action.option_strings:
+                    start, end = find_span(option_string)
+                    yield r.Span(start, end, "argparse.args")
+                    pos = end + 1
+                continue
             start, end = find_span(usage)
             yield r.Span(start, end, "argparse.args")
             pos = end + 1
@@ -337,7 +333,7 @@ def _rich_metavar_parts(
                 ("]", False),
             )
         elif action.nargs == argparse.ZERO_OR_MORE:
-            if sys.version_info < (3, 9) or len(get_metavar(1)) == 2:  # pragma: <3.9 cover
+            if len(get_metavar(1)) == 2:
                 metavar = get_metavar(2)
                 # '[%s [%s ...]]' % metavar
                 yield from (
@@ -349,7 +345,7 @@ def _rich_metavar_parts(
                     ("...", True),
                     ("]]", False),
                 )
-            else:  # pragma: >=3.9 cover
+            else:
                 # '[%s ...]' % metavar
                 yield from (
                     ("[", False),
@@ -459,7 +455,7 @@ def _rich_expand_help(self, action: Action) -> r.Text:
                         for m in re.finditer(rf"\[([^\]]*{printf_pat}[^\]]*)\]", help_string, re.X)
                         if m.group("mapping") == "default"
                     ),
-                    "default: %(default)s",  # pragma: >=3.9 cover # fails on Python 3.8!
+                    "default: %(default)s",
                 )
                 msg = (
                     f"Failed to process default value in help string of argument {action_id!r}."

scripts/run-tests

@@ -2,6 +2,6 @@
 
 set -euxo pipefail
 
-for python in 3.{8..14}; do
+for python in 3.{9..14}; do
     uvx --python=${python} --with=. --with-requirements=tests/requirements.txt pytest --cov
 done

tests/test_argparse.py

@@ -362,18 +362,12 @@ def test_actions_spans_in_usage():
     mut_ex.add_argument("--opt", nargs="?")
     mut_ex.add_argument("--opts", nargs="+")
 
-    # https://github.com/python/cpython/issues/82619
-    if sys.version_info < (3, 9):  # pragma: <3.9 cover
-        zom_metavar = "[\x1b[36mzom\x1b[0m [\x1b[36mzom\x1b[0m \x1b[36m...\x1b[0m]]"
-    else:  # pragma: >=3.9 cover
-        zom_metavar = "[\x1b[36mzom\x1b[0m \x1b[36m...\x1b[0m]"
-
     usage_text = (
-        f"\x1b[38;5;208mUsage:\x1b[0m \x1b[38;5;244mPROG\x1b[0m [\x1b[36m-h\x1b[0m] "
-        f"[\x1b[36m--opt\x1b[0m [\x1b[38;5;36mOPT\x1b[0m] | "
-        f"\x1b[36m--opts\x1b[0m \x1b[38;5;36mOPTS\x1b[0m [\x1b[38;5;36mOPTS\x1b[0m \x1b[38;5;36m...\x1b[0m]]\n                "
-        f"\x1b[36mrequired\x1b[0m \x1b[36mint\x1b[0m \x1b[36mint\x1b[0m [\x1b[36moptional\x1b[0m] "
-        f"{zom_metavar} \x1b[36moom\x1b[0m [\x1b[36moom\x1b[0m \x1b[36m...\x1b[0m] \x1b[36m...\x1b[0m \x1b[36mparser\x1b[0m \x1b[36m...\x1b[0m"
+        "\x1b[38;5;208mUsage:\x1b[0m \x1b[38;5;244mPROG\x1b[0m [\x1b[36m-h\x1b[0m] "
+        "[\x1b[36m--opt\x1b[0m [\x1b[38;5;36mOPT\x1b[0m] | "
+        "\x1b[36m--opts\x1b[0m \x1b[38;5;36mOPTS\x1b[0m [\x1b[38;5;36mOPTS\x1b[0m \x1b[38;5;36m...\x1b[0m]]\n                "
+        "\x1b[36mrequired\x1b[0m \x1b[36mint\x1b[0m \x1b[36mint\x1b[0m [\x1b[36moptional\x1b[0m] "
+        "[\x1b[36mzom\x1b[0m \x1b[36m...\x1b[0m] \x1b[36moom\x1b[0m [\x1b[36moom\x1b[0m \x1b[36m...\x1b[0m] \x1b[36m...\x1b[0m \x1b[36mparser\x1b[0m \x1b[36m...\x1b[0m"
     )
     expected_help_output = f"""\
     {usage_text}
@@ -396,9 +390,8 @@ def test_actions_spans_in_usage():
     assert parser.format_help() == clean_argparse(expected_help_output)
 
 
-@pytest.mark.skipif(sys.version_info < (3, 9), reason="not available in 3.8")
 @pytest.mark.usefixtures("force_color")
-def test_boolean_optional_action_spans():  # pragma: >=3.9 cover
+def test_boolean_optional_action_spans():
     parser = ArgumentParser("PROG", formatter_class=RichHelpFormatter)
     parser.add_argument("--bool", action=argparse.BooleanOptionalAction)
     expected_help_output = """\
@@ -732,8 +725,9 @@ def test_rich_lazy_import():
         if mod_name != "rich" and not mod_name.startswith("rich.")
     }
     lazy_rich = {k: v for k, v in r.__dict__.items() if k not in r.__all__}
-    with patch.dict(sys.modules, sys_modules_no_rich, clear=True), patch.dict(
-        r.__dict__, lazy_rich, clear=True
+    with (
+        patch.dict(sys.modules, sys_modules_no_rich, clear=True),
+        patch.dict(r.__dict__, lazy_rich, clear=True),
     ):
         parser = ArgumentParser(formatter_class=RichHelpFormatter)
         parser.add_argument("--foo", help="foo help")
@@ -809,8 +803,9 @@ def test_legacy_windows():  # pragma: win32 cover
     # Legacy windows console on new windows => colors: YES, initialization: YES
     init_win_colors = Mock(return_value=True)
     parser = ArgumentParser("PROG", formatter_class=RichHelpFormatter)
-    with patch("rich.console.detect_legacy_windows", return_value=True), patch(
-        "rich_argparse._common._initialize_win_colors", init_win_colors
+    with (
+        patch("rich.console.detect_legacy_windows", return_value=True),
+        patch("rich_argparse._common._initialize_win_colors", init_win_colors),
     ):
         help = parser.format_help()
     assert help == clean_argparse(expected_colored_output)
@@ -819,8 +814,9 @@ def test_legacy_windows():  # pragma: win32 cover
     # Legacy windows console on old windows => colors: NO, initialization: YES
     init_win_colors = Mock(return_value=False)
     parser = ArgumentParser("PROG", formatter_class=RichHelpFormatter)
-    with patch("rich.console.detect_legacy_windows", return_value=True), patch(
-        "rich_argparse._common._initialize_win_colors", init_win_colors
+    with (
+        patch("rich.console.detect_legacy_windows", return_value=True),
+        patch("rich_argparse._common._initialize_win_colors", init_win_colors),
     ):
         help = parser.format_help()
     assert help == clean_argparse(expected_output)
@@ -834,8 +830,9 @@ def fmt_no_color(prog):
 
     init_win_colors = Mock(return_value=True)
     no_colors_parser = ArgumentParser("PROG", formatter_class=fmt_no_color)
-    with patch("rich.console.detect_legacy_windows", return_value=True), patch(
-        "rich_argparse._common._initialize_win_colors", init_win_colors
+    with (
+        patch("rich.console.detect_legacy_windows", return_value=True),
+        patch("rich_argparse._common._initialize_win_colors", init_win_colors),
     ):
         help = no_colors_parser.format_help()
     assert help == clean_argparse(expected_output)
@@ -1067,10 +1064,6 @@ def test_metavar_spans():
     meg.add_argument("--op7", metavar=("MET1", "MET2", "MET3"), nargs=3)
     help_text = parser.format_help()
 
-    op3_metavar = "[\x1b[38;5;36mOP3\x1b[0m \x1b[38;5;36m...\x1b[0m]"
-    if sys.version_info < (3, 9):  # pragma: <3.9 cover
-        op3_metavar = f"[\x1b[38;5;36mOP3\x1b[0m {op3_metavar}]"
-
     if sys.version_info >= (3, 13):  # pragma: >=3.13 cover
         usage_tail = """ |
                 \x1b[36m--op2\x1b[0m [\x1b[38;5;36mMET1\x1b[0m [\x1b[38;5;36mMET2\x1b[0m \x1b[38;5;36m...\x1b[0m]] |
@@ -1081,11 +1074,11 @@ def test_metavar_spans():
                 \x1b[36m--op7\x1b[0m \x1b[38;5;36mMET1\x1b[0m \x1b[38;5;36mMET2\x1b[0m \x1b[38;5;36mMET3\x1b[0m]
         """
     else:  # pragma: <3.13 cover
-        usage_tail = f"""
+        usage_tail = """
                 | \x1b[36m--op2\x1b[0m
                 [\x1b[38;5;36mMET1\x1b[0m [\x1b[38;5;36mMET2\x1b[0m \x1b[38;5;36m...\x1b[0m]]
                 | \x1b[36m--op3\x1b[0m
-                {op3_metavar}
+                [\x1b[38;5;36mOP3\x1b[0m \x1b[38;5;36m...\x1b[0m]
                 | \x1b[36m--op4\x1b[0m
                 \x1b[38;5;36mMET1\x1b[0m
                 [\x1b[38;5;36mMET2\x1b[0m \x1b[38;5;36m...\x1b[0m]
@@ -1109,7 +1102,7 @@ def test_metavar_spans():
         \x1b[39mmessage and exit\x1b[0m
       \x1b[36m--op1\x1b[0m [\x1b[38;5;36mMET\x1b[0m]
       \x1b[36m--op2\x1b[0m [\x1b[38;5;36mMET1\x1b[0m [\x1b[38;5;36mMET2\x1b[0m \x1b[38;5;36m...\x1b[0m]]
-      \x1b[36m--op3\x1b[0m {op3_metavar}
+      \x1b[36m--op3\x1b[0m [\x1b[38;5;36mOP3\x1b[0m \x1b[38;5;36m...\x1b[0m]
       \x1b[36m--op4\x1b[0m \x1b[38;5;36mMET1\x1b[0m [\x1b[38;5;36mMET2\x1b[0m \x1b[38;5;36m...\x1b[0m]
       \x1b[36m--op5\x1b[0m \x1b[38;5;36mOP5\x1b[0m [\x1b[38;5;36mOP5\x1b[0m \x1b[38;5;36m...\x1b[0m]
       \x1b[36m--op6\x1b[0m \x1b[38;5;36mOP6\x1b[0m \x1b[38;5;36mOP6\x1b[0m \x1b[38;5;36mOP6\x1b[0m

tests/test_optparse.py

@@ -301,8 +301,9 @@ def test_rich_lazy_import():
         if mod_name != "rich" and not mod_name.startswith("rich.")
     }
     lazy_rich = {k: v for k, v in r.__dict__.items() if k not in r.__all__}
-    with patch.dict(sys.modules, sys_modules_no_rich, clear=True), patch.dict(
-        r.__dict__, lazy_rich, clear=True
+    with (
+        patch.dict(sys.modules, sys_modules_no_rich, clear=True),
+        patch.dict(r.__dict__, lazy_rich, clear=True),
     ):
         parser = OptionParser(formatter=IndentedRichHelpFormatter())
         parser.add_option("--foo", help="foo help")
@@ -353,8 +354,9 @@ def test_legacy_windows(legacy_console, old_windows, colors):  # pragma: win32 c
 
     init_win_colors = Mock(return_value=not old_windows)
     parser = OptionParser(prog="PROG", formatter=IndentedRichHelpFormatter())
-    with patch("rich.console.detect_legacy_windows", return_value=legacy_console), patch(
-        "rich_argparse._common._initialize_win_colors", init_win_colors
+    with (
+        patch("rich.console.detect_legacy_windows", return_value=legacy_console),
+        patch("rich_argparse._common._initialize_win_colors", init_win_colors),
     ):
         assert parser.format_help() == dedent(expected_output)
     if legacy_console: