From 0ccf753c269591b67004530f111f30d6037d6539 Mon Sep 17 00:00:00 2001 From: Andrea Sonny Date: Tue, 17 May 2016 13:58:39 +0100 Subject: [PATCH 1/2] Code improvement * better JavaScript global abatement technique solution --- src/hammer.prefix.js | 4 +++- src/hammer.suffix.js | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/hammer.prefix.js b/src/hammer.prefix.js index debc7fff2..1efdb3457 100644 --- a/src/hammer.prefix.js +++ b/src/hammer.prefix.js @@ -1,2 +1,4 @@ -(function(window, document, exportName, undefined) { +(function(window, exportName, undefined) { 'use strict'; + + var document = window.document; diff --git a/src/hammer.suffix.js b/src/hammer.suffix.js index 41bfecfc2..a339964de 100644 --- a/src/hammer.suffix.js +++ b/src/hammer.suffix.js @@ -1 +1 @@ -})(window, document, 'Hammer'); +})(typeof window !== "undefined" ? window : this, 'Hammer'); From b780b24632984ce47b07661f2e8376e16d5cfd98 Mon Sep 17 00:00:00 2001 From: Andrea Sonny Date: Tue, 17 May 2016 15:13:04 +0100 Subject: [PATCH 2/2] fixing some codestyleguide issue --- src/hammer.prefix.js | 2 -- src/hammer.suffix.js | 2 +- src/utils.js | 2 ++ 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/hammer.prefix.js b/src/hammer.prefix.js index 1efdb3457..9d9cedabd 100644 --- a/src/hammer.prefix.js +++ b/src/hammer.prefix.js @@ -1,4 +1,2 @@ (function(window, exportName, undefined) { 'use strict'; - - var document = window.document; diff --git a/src/hammer.suffix.js b/src/hammer.suffix.js index a339964de..1283946ec 100644 --- a/src/hammer.suffix.js +++ b/src/hammer.suffix.js @@ -1 +1 @@ -})(typeof window !== "undefined" ? window : this, 'Hammer'); +})(typeof window !== 'undefined' ? window : this, 'Hammer'); diff --git a/src/utils.js b/src/utils.js index c923ce533..29618b606 100644 --- a/src/utils.js +++ b/src/utils.js @@ -1,3 +1,5 @@ +var document = window.document; + var VENDOR_PREFIXES = ['', 'webkit', 'Moz', 'MS', 'ms', 'o']; var TEST_ELEMENT = document.createElement('div');