fix broken image links #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed broken image links in shopping carts and some images from the index.js, -removed TAP.TO as they don't operate anymore (their web doesn't exist anymore)
raul-handpoint
approved these changes
Apr 25, 2025
raul-handpoint
left a comment
raul-handpoint
left a comment
There was a problem hiding this comment.
Approved with a lil suggestion.
| <img style={{height: '50px'}} | ||
| src="https://www.admit-one.eu/images/admit-one_logo_red_rgb.svg" | ||
| src="/img/admitOne.jpg" | ||
| alt="Image alt text" |
There was a problem hiding this comment.
suggestion [non-blocking]: It would be nice to correctly fill the alt attribute for the visually impaired readers.
Author
There was a problem hiding this comment.
Thanks Raul I agree, and also to keep all the images sources hosted on our side and not depending on 3rd parties, this was a quick fix to the links that were broken, but a second iteration can contain moving all images to be hosted locally and applying descriptive Alt text as a fallback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed broken image links in shopping carts and some images from the index.js, -removed TAP.TO as they don't operate anymore (their web doesn't exist anymore)