From c2092dcec5439b50e4e00aab25ef7de8a2c32c82 Mon Sep 17 00:00:00 2001
From: Aaron Krause <aaroncrows@Aarons-MacBook-Pro.local>
Date: Thu, 19 Jan 2017 10:50:05 -0800
Subject: [PATCH] submission comments

---
 about.html |  1 +
 app.js     | 14 ++++++++++++++
 style.css  | 27 ++++++++++++++++++++++++++-
 3 files changed, 41 insertions(+), 1 deletion(-)

diff --git a/about.html b/about.html
index c58f2b3..c02fe68 100644
--- a/about.html
+++ b/about.html
@@ -12,6 +12,7 @@ <h1>HANGMAN</h1>
     <main id="main_about">
       <h2>About the developers</h2>
     </br>
+      <!-- These divs probably could have been named a bit more semantically -->
       <div id="developers">
         <div class="developer_bio">
           <div>
diff --git a/app.js b/app.js
index 724401c..6347e2a 100644
--- a/app.js
+++ b/app.js
@@ -91,6 +91,13 @@ function renderPlayerStatsRow(currentPlayer) {
   var totalPointsPlayer = document.createElement('td');
 
   playerTableRow.appendChild(rankingPlayer);
+  //even though these are property names you could still loop through them
+  //with a for loop. Something like:
+  //for (var key in currentPlayer) {
+  //td = document.createElement('td')
+  //td.textContent = currentPlayer[key]
+  //
+  //}
 
   playerNamePlayer.textContent = currentPlayer.playerName;
   playerTableRow.appendChild(playerNamePlayer);
@@ -156,6 +163,8 @@ function generateRandomNumber(arr) {
 
 // initiate the playerAnswerArr to '_' characters, the length of the gameWord
 function generatePlayerAnswerArray (gameWord) {
+  //careful using push here. If you don't reset the array you could keep tacking
+  //things on. Defensively you could reset it here (playerAnswerArr = [])
   for (var i = 0; i < gameWord.length; i++) {
     playerAnswerArr.push('_');
   };
@@ -177,6 +186,8 @@ function handleClick(event) {
   event.preventDefault(); // prevent page refresh
 
   // determine if the event.target.value is in the gameWord array
+  //includes! nice.  Includes returns a boolean. So comparing it to true is
+  //the same as just calling it.
   if (gameWord.includes(event.target.value) === true) {
     // loop through the gameWord to match target value (letter) with any same letter in the gameword
     for (var i = 0; i < gameWord.length; i++) {
@@ -192,6 +203,7 @@ function handleClick(event) {
         checkForWin();
       }
     }
+    //since there are only two cases this could just be an else
   } else if (gameWord.includes(event.target.value) === false) {
     // if user selects a invalid letter, nothing changes in the playerAnswerArr
     displayPlayerArray(playerAnswerArr);
@@ -282,6 +294,7 @@ function setRank(){
   }
   for (var i = 0; i < playersLength; i++) {
     rank = rank + 1;
+    //you could also just use i here
     parsedlclStrgObjArr[i].ranking = rank;
   }
 };
@@ -305,6 +318,7 @@ function storePreviousPlayer() {
 // handles the event when 'play again' button is clicked
 function handlePlayAgain(event) {
   // reloads the page and starts it at the top
+  //neat!
   window.location.reload();
   window.onbeforeunload = function () {
     window.scrollTo(0, 0);
diff --git a/style.css b/style.css
index 981e5b3..59aea65 100644
--- a/style.css
+++ b/style.css
@@ -224,7 +224,32 @@ main h2 {
 .clear_fix {
   clear: left;
 }
-
+/*
+  #donate_button, #home_button and .page_button all have at least
+  rules in common. I would either extract those rules to another class
+  and put it on all of the elements that have those same rules or combine
+  the selectors e.g:
+
+  #donate_button, #home_button, .page_button {
+    text-align: center;
+    color: rgba(255, 255, 255, .8);
+    font-family: sans-serif;
+    font-size: 12pt;
+    border: none;
+    box-shadow: 5px 5px 3px #5C5C5C;
+  }
+
+  or
+
+  .basic_button_styles {
+    text-align: center;
+    color: rgba(255, 255, 255, .8);
+    font-family: sans-serif;
+    font-size: 12pt;
+    border: none;
+    box-shadow: 5px 5px 3px #5C5C5C;
+  }
+*/
 #donate_button {
   display: block;
   margin: 0 auto 30px auto;