TEST/MINOR: gitlab: diff for swagger generated files

Author: prometherion

.gitlab-ci.yml

@@ -7,6 +7,24 @@ variables:
   DOCKER_BASE_IMAGE: $CI_REGISTRY_GO/haproxy-alpine
   BATS_VERSION: v1.4.1
 
+diff:
+  stage: lint
+  image:
+    name: $CI_REGISTRY_GO/docker:stable-go1.17
+    entrypoint: [ "" ]
+  services:
+    - name: $CI_REGISTRY_GO/docker:20.10.5-dind
+      alias: docker
+  tags:
+    - go
+  script:
+    #- apk add make curl bash jq
+    - SWAGGER_VERSION=$(curl -s https://raw.githubusercontent.com/haproxytech/client-native/master/Makefile | grep SWAGGER_VERSION -m 1 | awk -F"=" '{print $2}')
+    - wget -q "https://github.com/go-swagger/go-swagger/releases/download/${SWAGGER_VERSION}/swagger_linux_amd64" -O /usr/local/bin/swagger && chmod +x /usr/local/bin/swagger
+    - make generate-native
+    - test -z "$(git diff 2> /dev/null)" || exit "Specification is not generated, issue \`make swagger\` and commit the result"
+    - test -z "$(git ls-files --others --exclude-standard 2> /dev/null)" || exit "Specification generation created untracked files, cannot proceed"
+
 golangci-lint:
   stage: lint
   artifacts:

Makefile

@@ -34,7 +34,7 @@ generate:
 		--build-arg UID=$(shell id -u) \
 		--build-arg GID=$(shell id -g) \
 		-t dataplaneapi-swagger-gen .
-	docker run --rm -it -v "$(PWD)":/data dataplaneapi-swagger-gen
+	docker run --rm -v "$(PWD)":/data dataplaneapi-swagger-gen
 	generate/post_swagger.sh
 
 .PHONY: generate-native

generate/swagger/script.sh

@@ -17,7 +17,6 @@ fi
 # check if version is there, if not, use one from require
 [ -z "$CN_VERSION" ] && CN_VERSION=$(go mod edit -json | jq -c -r '.Require | .[] | select(.Path | contains("github.com/haproxytech/client-native/v2")) | .Version' 2>/dev/null | awk -F"-" '{print $NF}')
 echo " ---> version of client native used: $CN_VERSION"
-
 # extract repository
 REPO_PATH=$(go mod edit -json | jq -r '.Replace | .[] | select(.Old.Path | contains("github.com/haproxytech/client-native/v2")) | .New.Path'  2>/dev/null |  awk -F"/" '{print $2 "/" $3}') || ""
 [ -z "$REPO_PATH" ] && REPO_PATH=haproxytech/client-native
@@ -41,6 +40,7 @@ if [ "$REMOTE_VERSION" = "null" ]; then
 else
   echo " ---> URL path: $URL_PATH"
   echo " ---> repository path: $REPO_PATH"
+  echo " ---> client native version: $CN_VERSION"
   SPEC_URL=https://$URL_PATH/$REPO_PATH/$EXTRA_PATH$CN_VERSION/specification
 
   echo " ---> fetching specification: $SPEC_URL/build/haproxy_spec.yaml"