BUG/MINOR: userlists: fix error handling for users and groups

mjuraga · mjuraga · commit 88c5c2cb1646 · 2022-11-30T17:20:35.000+01:00
diff --git a/e2e/tests/groups/add.bats b/e2e/tests/groups/add.bats
@@ -30,7 +30,7 @@ load 'utils/_helpers'
 
 @test "groups: Add a group to a non existing user list" {
   resource_post "$_GROUPS_BASE_PATH" "data/post.json" "userlist=fake&=force_reload=true"
-  assert_equal "$SC" 400
+  assert_equal "$SC" 404
 }
 
 @test "groups: Add a malformed group" {
diff --git a/e2e/tests/groups/data/post.json b/e2e/tests/groups/data/post.json
@@ -1,5 +1,4 @@
 {
-    "index": 0,
     "name": "new",
     "users": null
 }
diff --git a/e2e/tests/groups/data/replace.json b/e2e/tests/groups/data/replace.json
@@ -1,5 +1,4 @@
 {
-    "index": 0,
-    "name": "enigma",
+    "name": "zion",
     "users": "trinity"
 }
diff --git a/e2e/tests/groups/replace.bats b/e2e/tests/groups/replace.bats
@@ -42,4 +42,3 @@ load 'utils/_helpers'
     resource_put "$_GROUPS_BASE_PATH/1000" "data/replace.json" "userlist=fake&force_reload=true"
     assert_equal "$SC" 404
 }
-
diff --git a/e2e/tests/users/data/post.json b/e2e/tests/users/data/post.json
@@ -1,5 +1,4 @@
 {
-    "index": 0,
     "username": "new",
     "secure_password": false,
     "password": "new",
diff --git a/e2e/tests/users/data/replace.json b/e2e/tests/users/data/replace.json
@@ -1,6 +1,5 @@
 {
-    "index": 0,
-    "username": "enigma",
+    "username": "trinity",
     "secure_password": false,
     "password": "reality",
     "groups": null
diff --git a/embedded_spec.go b/embedded_spec.go

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ load 'utils/_helpers'`
`30`	`30`
`31`	`31`	`@test "groups: Add a group to a non existing user list" {`
`32`	`32`	`resource_post "$_GROUPS_BASE_PATH" "data/post.json" "userlist=fake&=force_reload=true"`
`33`		`- assert_equal "$SC" 400`
	`33`	`+ assert_equal "$SC" 404`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`@test "groups: Add a malformed group" {`
Original file line number	Diff line number	Diff line change
`@@ -42,4 +42,3 @@ load 'utils/_helpers'`
`42`	`42`	`resource_put "$_GROUPS_BASE_PATH/1000" "data/replace.json" "userlist=fake&force_reload=true"`
`43`	`43`	`assert_equal "$SC" 404`
`44`	`44`	`}`
`45`		`-`