BUG/MINOR: Fix memory leaks with time.After()

Author: dkorunic

discovery/aws_service_discovery_instance.go

@@ -148,6 +148,9 @@ func (a *awsInstance) start() {
 	go func() {
 		a.logDebug("discovery job starting")
 
+		discoveryTimer := time.NewTimer(a.timeout)
+		defer discoveryTimer.Stop()
+
 		for {
 			select {
 			case _, ok := <-a.update:
@@ -166,7 +169,7 @@ func (a *awsInstance) start() {
 				if err != nil {
 					a.stop()
 				}
-			case <-time.After(a.timeout):
+			case <-discoveryTimer.C:
 				a.logDebug("discovery job update triggered")
 
 				var api *ec2.Client
@@ -192,6 +195,7 @@ func (a *awsInstance) start() {
 				}
 
 				a.logDebug("discovery job reconciliation completed")
+				discoveryTimer.Reset(a.timeout)
 			case <-a.ctx.Done():
 				a.stop()
 			}

discovery/consul_service_discovery_instance.go

@@ -86,6 +86,9 @@ func (c *consulInstance) setAPIClient() error {
 }
 
 func (c *consulInstance) watch() {
+	watchTimer := time.NewTimer(c.timeout)
+	defer watchTimer.Stop()
+
 	for {
 		select {
 		case _, ok := <-c.update:
@@ -112,13 +115,14 @@ func (c *consulInstance) watch() {
 			}
 		case <-c.ctx.Done():
 			c.stop()
-		case <-time.After(c.timeout):
+		case <-watchTimer.C:
 			c.logDebug("discovery job reconciliation started")
 			if err := c.updateServices(); err != nil {
 				// c.log.Errorf("error while updating service: %w", err)
 				c.stop()
 			}
 			c.logDebug("discovery job reconciliation completed")
+			watchTimer.Reset(c.timeout)
 		}
 	}
 }