BUG/MEDIUM: do not pull echo image from dockerhub, build it locally

Signed-off-by: Zlatko Bratkovic <zbratkovic@haproxy.com>

Author: oktalz

.gitlab-ci.yml

@@ -85,6 +85,10 @@ unit-tests:
     - docker login -u gitlab-ci-token -p $CI_BUILD_TOKEN $CI_REGISTRY_GO
   script:
     - go version
+    - docker pull $CI_REGISTRY_GO/alpine:3
+    - docker image tag $CI_REGISTRY_GO/alpine:3 alpine:3
+    - docker pull $CI_REGISTRY_GO/golang:1.17-alpine
+    - docker image tag $CI_REGISTRY_GO/golang:1.17-alpine golang:1.17-alpine
     - wget -q -o /dev/null -O &> /dev/null /usr/local/bin/kind https://github.com/kubernetes-sigs/kind/releases/download/${KIND}/kind-linux-amd64
     - chmod +x /usr/local/bin/kind
     - wget -q -o /dev/null -O &> /dev/null /usr/local/bin/kubectl https://storage.googleapis.com/kubernetes-release/release/${KUBECTL}/bin/linux/amd64/kubectl
@@ -97,26 +101,33 @@ unit-tests:
     - sed -i -E -e "s/localhost|0\.0\.0\.0|127\.0\.0\.1/docker/g" "$HOME/.kube/config"
     - sed -i -E -e "s/localhost|0\.0\.0\.0|127\.0\.0\.1/docker/g" "deploy/tests/e2e/client.go"
     - until kubectl get nodes -o wide;do sleep 2; done
+    - kubectl get pods -A
     - CI_ENV=gitlab deploy/tests/create.sh
+    - kubectl get pods -A
     - KIND_URL=docker CGO_ENABLED=0 go test -v ./deploy/tests/e2e/... --tags=e2e_parallel
     - KIND_URL=docker CGO_ENABLED=0 go test -v -p 1 ./deploy/tests/e2e/... --tags=e2e_sequential
   after_script:
+    - kubectl get pods -A
     - kind delete cluster --name=dev
   only:
     - merge_requests
     - branches
-k8s_19:
+.kind_deployment_schedules:
   only:
     - schedules
+  extends: .kind_deployment
+k8s_18:
+  variables:
+    K8S_VERSION: v1.18.19
+  extends: .kind_deployment_schedules
+k8s_19:
   variables:
     K8S_VERSION: v1.19.11
-  extends: .kind_deployment
+  extends: .kind_deployment_schedules
 k8s_20:
-  only:
-    - schedules
   variables:
     K8S_VERSION: v1.20.7
-  extends: .kind_deployment
+  extends: .kind_deployment_schedules
 k8s_21:
   variables:
     K8S_VERSION: v1.21.1

deploy/tests/README.md

@@ -27,7 +27,7 @@ This will also deploy the HAProxy Ingress Controller using config in `deploy/tes
 kubectl apply -f ./config/echo-app.yaml
 ```
 
-Deploys [http-echo](https://github.com/Mo3m3n/http-echo) as a test application.
+Deploys `haproxytech/http-echo` as a test application.
 
 ```bash
 curl --header "Host: echo.haproxy.local" 127.0.0.1:30080
@@ -41,22 +41,22 @@ Response will include a couple of useful information:
 ### E2E tests
 
 ```bash
-go test -v --tags=<tag_name> ./e2e/... 
+go test -v --tags=<tag_name> ./e2e/...
 ```
 
-This will run all e2e tests in `./e2e` directory tagged with `<tag_name>`.  
+This will run all e2e tests in `./e2e` directory tagged with `<tag_name>`.
 There are two available tags:
-- **e2e_parallel**: which will run tests in parallel 
+- **e2e_parallel**: which will run tests in parallel
 - **e2e_sequential**: which will run tests in sequence
 
 Currently two tests are run sequentially:
 - endpoints: in order to test endpoints scaling without reloading haproxy.
 - tls-auth:  tls authentication is a global config that will impact other tests running in parallel.
 
-Each E2E test runs in its **own Namespace** and has its own directory.  
-Tests are deployed by applying yaml files or/and templates from the `config` directory of the corresponding test.  
-When using yaml templates, the generated yaml files are stored in a temporary directory in `/tmp/`.  
-Using `--dev` option will keep generated files after test execution.  
+Each E2E test runs in its **own Namespace** and has its own directory.
+Tests are deployed by applying yaml files or/and templates from the `config` directory of the corresponding test.
+When using yaml templates, the generated yaml files are stored in a temporary directory in `/tmp/`.
+Using `--dev` option will keep generated files after test execution.
 Example:
 ```bash
 go test -v --tags=e2e_sequential --dev ./e2e/endpoints/

deploy/tests/config/echo-app.yaml

@@ -14,7 +14,8 @@ spec:
     spec:
       containers:
         - name: http-echo
-          image: 'mo3m3n/http-echo:v1.0.0'
+          image: 'haproxytech/http-echo:latest'
+          imagePullPolicy: Never
           ports:
             - name: http
               containerPort: 8888

deploy/tests/create.sh

@@ -31,6 +31,10 @@ else
   kind load docker-image haproxytech/kubernetes-ingress:latest  --name=$clustername
 fi
 
+docker build --build-arg TARGETPLATFORM="linux/amd64" -t haproxytech/http-echo -f deploy/tests/images/http-echo/Dockerfile deploy/tests/images/http-echo
+echo "loading image http-echo in kind"
+kind load docker-image haproxytech/http-echo:latest  --name=$clustername
+
 echo "deploying Ingress Controller ..."
 kubectl apply -f $DIR/config/0.namespace.yaml
 kubectl apply -f $DIR/config/1.default-backend.yaml

deploy/tests/e2e/basic-auth/config/deploy.yaml.tmpl

@@ -27,7 +27,8 @@ spec:
     spec:
       containers:
         - name: http-echo
-          image: mo3m3n/http-echo:v1.0.0
+          image: haproxytech/http-echo:latest
+          imagePullPolicy: Never
           args:
           - --default-response=hostname
           ports:
@@ -71,4 +72,4 @@ spec:
           - path: /
             backend:
               serviceName: http-echo
-              servicePort: http    
+              servicePort: http

deploy/tests/e2e/canary-deployment/config/deploy.yaml.tmpl

@@ -17,7 +17,8 @@ spec:
     spec:
       containers:
         - name: http-echo-prod
-          image: mo3m3n/http-echo:v1.0.0
+          image: haproxytech/http-echo:latest
+          imagePullPolicy: Never
           args:
           - --default-response=hostname
           ports:
@@ -56,7 +57,8 @@ spec:
     spec:
       containers:
         - name: http-echo-staging
-          image: mo3m3n/http-echo:v1.0.0
+          image: haproxytech/http-echo:latest
+          imagePullPolicy: Never
           args:
           - --default-response=hostname
           ports:

deploy/tests/e2e/config-snippet/config/deploy.yaml.tmpl

@@ -15,7 +15,8 @@ spec:
     spec:
       containers:
         - name: http-echo
-          image: mo3m3n/http-echo:v1.0.0
+          image: haproxytech/http-echo:latest
+          imagePullPolicy: Never
           args:
           ports:
             - name: http

deploy/tests/e2e/endpoints/config/endpoints.yaml.tmpl

@@ -11,7 +11,8 @@ spec:
     spec:
       containers:
         - name: http-echo
-          image: mo3m3n/http-echo:v1.0.0
+          image: haproxytech/http-echo:latest
+          imagePullPolicy: Never
           args:
           - --default-response=hostname
           ports:

deploy/tests/e2e/https/config/deploy.yaml

@@ -15,7 +15,8 @@ spec:
     spec:
       containers:
         - name: http-echo
-          image: mo3m3n/http-echo:v1.0.0
+          image: haproxytech/http-echo:latest
+          imagePullPolicy: Never
           args:
           ports:
             - name: http

deploy/tests/e2e/ingress-match/config/deploy.yaml.tmpl

@@ -16,7 +16,8 @@ spec:
     spec:
       containers:
         - name: http-echo-{{$i}}
-          image: mo3m3n/http-echo:v1.0.0
+          image: haproxytech/http-echo:latest
+          imagePullPolicy: Never
           args:
           - --default-response=hostname
           ports: